Change for loop to while loop.

[mdgrogan]

Change for loop to a while loop so that we don't skip items and overshoot the end of the container when erasing.

[matt-attack]

Nevermind. Discussion cleared this up.

[danthony06]

It looks like with the change it's possible to dereference an invalid iterator.

…

On Tue, Dec 3, 2019, 3:36 PM Matthew ***@***.***> wrote: I'm not sure that I see a difference in what is executed here. Does this fix a crash? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#663?email_source=notifications&email_token=ABBZWHDACM3WA24IMCNNOQLQW3GNHA5CNFSM4JU64W7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF24VWY#issuecomment-561367771>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBZWHHRYFGUL4BNKAMQ4DLQW3GNHANCNFSM4JU64W7A> .

[mdgrogan]

Where does that occur?

[danthony06]

Sorry about that, I misread the code on my phone and thought the continue statements had been removed. I'm still not sure what problem this change is addressing.

…

On Tue, Dec 3, 2019 at 4:38 PM Matthew Grogan ***@***.***> wrote: Where does that occur? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#663?email_source=notifications&email_token=ABBZWHG5JR5KE5TVEPHCLQDQW3NVJA5CNFSM4JU64W7KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF3B6AQ#issuecomment-561389314>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABBZWHBSARTVSZJ6L6I2CR3QW3NVJANCNFSM4JU64W7A> .

[mdgrogan]

Ah, no worries. The erase function returns the next iterator and at the end of the for loop, that iterator will be incremented again. So it potentially skips items and increments the iterator past end.