Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make string plugin also support string stamped #666

Merged
merged 2 commits into from
Apr 3, 2020
Merged

Make string plugin also support string stamped #666

merged 2 commits into from
Apr 3, 2020

Conversation

matt-attack
Copy link
Contributor

No description provided.

daniel-dsouza
daniel-dsouza suggested changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@daniel-dsouza daniel-dsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the macro, this looks good to m e.

mapviz_plugins/src/string_plugin.cpp Outdated Show resolved Hide resolved
@matt-attack
Copy link
Contributor Author

@pjreed I accidentally pushed this to origin. Is there a way to delete that branch?

@matt-attack
Copy link
Contributor Author

apart from the macro, this looks good to m e.

@daniel-dsouza should be good now

@pjreed
Copy link
Contributor

pjreed commented Jan 3, 2020

@pjreed I accidentally pushed this to origin. Is there a way to delete that branch?

Sure, done.

@daniel-dsouza
Copy link
Contributor

@pjreed looks good to merge

@pjreed pjreed merged commit 2dac5a7 into swri-robotics:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjreed pjreed pjreed left review comments

@daniel-dsouza daniel-dsouza daniel-dsouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matt-attack @pjreed @daniel-dsouza