Add route speed functions #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this with master? |
elliotjo
force-pushed
the
add-route-speed-functions
branch
from
ad7ac0b
to
260af63
Compare
|
Rebased |
evenator
reviewed
Jul 28, 2017
swri_route_util/CMakeLists.txt
Outdated
| @@ -4,6 +4,8 @@ project(swri_route_util) | |||
| set(BUILD_DEPS | |||
| marti_nav_msgs | |||
There was a problem hiding this comment.
It looks like you're missing dependencies on marti_common_msgs, swri_route_util, and visualization_msgs.
| @@ -16,6 +16,8 @@ | |||
| <depend>marti_nav_msgs</depend> | |||
| <depend>roscpp</depend> | |||
| <depend>swri_transform_util</depend> | |||
| <depend>swri_math_util</depend> | |||
| <depend>swri_geometry_util</depend> | |||
There was a problem hiding this comment.
See my comment on CMakeLists.txt about missing dependencies.
| swri_math_util::Interpolation1D speed_curve_; | ||
|
|
||
| // Filter constant used when estimating route curvature. Larger | ||
| // values result in smoother curvature estiamtes with fewer spikes. |
added 7 commits
July 28, 2017 13:22
Nothing implemented yet, just setting precedence for the approach.
This commit fixes two issues found in the last commit. A boolean value was inverted causing all obstacles to be ignored, and a loop index variable was being incremented twice.
Fixing issues raised by Ed on github and removing trailing whitespace.
elliotjo
force-pushed
the
add-route-speed-functions
branch
from
c6d762c
to
f8d2da8
Compare
|
Addressed Ed's comments and rebased again. |
|
Is the build failure unrelated? |
|
@malban It looks like we have some flaky tests in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.