Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PerpendicularPlaneWithPoint RANSAC model #487

Merged
merged 3 commits into from Sep 29, 2017

Conversation

matt-attack
Copy link
Contributor

This model takes in a point on the plane and a perpendicular axis and tolerance angle from which the plane normal must be to it.

return true;
}

void PerpendicularPlaneWithPointFit::CalculateNorms(const M& model, cv::Mat& norms)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't this method just be inherited?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be and is now, it wasn’t working before but I had some other error which I found after I changed it.

@@ -218,6 +218,31 @@ namespace swri_opencv_util
float min_angle_;
};

class PerpendicularPlaneWithPointFit : public PlaneFit//Fit3d<PlaneModel>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out code

@malban malban merged commit de893e2 into swri-robotics:master Sep 29, 2017
@matt-attack matt-attack deleted the add-ppwp-model branch October 6, 2017 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants