Ensure all swri::Subscriber members are initialized #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As long as I'm in here, looking at subscriber_impl.h:73, it appears that if the stamp in a header is 0, this will very quickly cause an overflow of |
elliotjo
reviewed
Dec 14, 2017
| @@ -75,7 +75,8 @@ class SubscriberImpl | |||
| min_latency_ = latency; | |||
| max_latency_ = latency; | |||
| total_latency_ = latency; | |||
| } else { | |||
| } | |||
| else { | |||
There was a problem hiding this comment.
Recommend undoing these style changes to remain consistent.
There was a problem hiding this comment.
Any opinions on how that check should be handled if the header stamp isn't set?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some member variables in swri::Subscriber were uninitialized by default; this ensures all of them are initialized.