Add function to test if two line segments intersect. #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjreed
suggested changes
Oct 22, 2018
| * In the case of parallel overlapping segments, the intersection point | ||
| * closest to p1 is returned. | ||
| * | ||
| * @param[in] p1 First point of line segemnt 1. |
There was a problem hiding this comment.
Fixed typo in this function and the existing function above it.
| * @returns True if the line segments intersect. | ||
| */ | ||
| bool LineSegmentIntersection( | ||
| cv::Vec2d p1, |
There was a problem hiding this comment.
All of the in-arguments to both this and PointOnLineSegment can probably be const references.
There was a problem hiding this comment.
Fixed the parameters in this function and the existing function above it.
pjreed
approved these changes
Oct 22, 2018
|
Sigh... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.