Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language Server does not detect invalid references #57

Closed
alcarney opened this issue Jan 22, 2021 · 0 comments · Fixed by #112
Closed

Language Server does not detect invalid references #57

alcarney opened this issue Jan 22, 2021 · 0 comments · Fixed by #112
Labels
enhancement New feature or request lsp Issues that relate to the language server

Comments

@alcarney
Copy link
Member

alcarney commented Jan 22, 2021 •
edited
Loading

For example the reference :ref:`not-a-valid-reference` is not flagged as an issue
Not sure if this should be solved by running more of the Sphinx build process (current we only read the sources) or if there should be a dedicated feature that checks for this kind of thing
@alcarney alcarney added bug Something isn't working lsp Issues that relate to the language server enhancement New feature or request and removed bug Something isn't working labels Jan 22, 2021
@alcarney alcarney mentioned this issue Feb 24, 2021
Merged
alcarney added a commit that referenced this issue Feb 24, 2021
@alcarney
Catch consistency errors. (#112)
8771669 
By running the full build, we are now able to catch errors like
invalid references and benefit from Sphinx's caching logic.

Also by updating the `PROBLEM_PATTERN` regex, we can catch errors
that do not have an associated line number.

`DiagnosticList` is a way to ensure we don't get repeat reports of
the same issue, but might become a performance issue depending on project scale.

Closes #94 
Closes #57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request lsp Issues that relate to the language server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Catch consistency errors. alcarney/esbonio
1 participant
@alcarney