Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small classes shouldn't be version #5986

Open
nilsdeppe opened this issue May 12, 2024 · 0 comments
Open

Small classes shouldn't be version #5986

nilsdeppe opened this issue May 12, 2024 · 0 comments
Assignees

Comments

@nilsdeppe
Copy link
Member

We are currently versioning a lot of tiny classes (inconsistently) all to version the Domain we write into the HDF5 files. One example is Direction, where the fact that we version it actually doubles the size of the serialized object. Another is FixedHashMap. This also greatly restricts our ability to change the code. Given that we don't have a stable release where we can do the science we want, this extreme versioning of everything actually hinders development. For example, while making changes to Direction I spent more time dealing with versioning than with actually changing the code. The versioning should be purely handled at the Domain level since that's the class we actually care about. This is what I've seen in industry and is actually scalable, whereas our current approach I think is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants