Add ExportCoordinates executable #1417
Conversation
nilsvu
force-pushed
the
spec_initial_data
branch
from
ef6fbb2
to
700ef07
Compare
There was a problem hiding this comment.
Only some minor high level comments from me 👍
Also, it may be beyond the scope of this PR, but it would be nice to be able to visualize a domain in paraview without running a simulation using that domain. It was something I was considering figuring out how to do myself, but if this executable is not too far from being able to accomplish that, then that is something I would appreciate having 😄
|
@gsb76 indeed you can use this executable to output the grid of a domain and then run any of our visualisation tools over it. (That's an overstatement, there's really only
|
|
@kidder could you review this or find a reviewer? |
|
Yes, I can review it |
| template <size_t Dim> | ||
| struct Metavariables { | ||
| static constexpr OptionString help{ | ||
| "Export the domain coordinates. The output can be used to compute " |
There was a problem hiding this comment.
Export the inertial coordinates of the Domain specified in the input file. ...
| #include "Utilities/TMPL.hpp" | ||
|
|
||
| namespace { | ||
| // We only need this type for the `ObservationId`. Can be removed with #1408. |
nilsvu
force-pushed
the
spec_initial_data
branch
2 times, most recently
from
5434660
to
436e89e
Compare
|
@kidder addressed your comments, please check the fixups |
|
okay, please squash |
This executable is useful to export the domain coordinates so that we can interpolate externally computed initial data to it.
nilsvu
force-pushed
the
spec_initial_data
branch
from
436e89e
to
bbeaeb2
Compare
|
done @kidder |
|
@gsb76 could you sign off on this when you get the chance? |
Proposed changes
This executable is useful to export the domain coordinates so that we can interpolate externally computed initial data to it.
Once the Kerr executable is evolving (#1358) the idea is to compute initial data for a perturbed Kerr black hole with SpEC, interpolate it to our domain and try to evolve that. To do that we can export our domain coordinates with this executable, use the SpEC tools to interpolate to these coordinates, and then import the interpolated data. I will provide Python code to do the interpolation with SpEC and the importing functionality in a future PR.
Types of changes:
Component:
Code review checklist
clang-tidyandIWYU.For instructions on how to perform the CI checks locally refer to the Dev
guide on the Travis CI.
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.