Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gif support? #1195

Closed
1 task done
JustinBacher opened this issue Jun 23, 2024 · 4 comments
Closed
1 task done

Gif support? #1195

JustinBacher opened this issue Jun 23, 2024 · 4 comments
Labels
feature New feature request

Comments

@JustinBacher
Copy link

Please describe the problem you're trying to solve

I see on that this has not yet been requested. Is this planned? Is this something you're hoping someone would implement in a PR?

I could see about getting this working although I don't have a clue where to start if I could get a nudge in the right direction.

Would you be willing to contribute this feature?

  • Yes, I'll give it a shot

Describe the solution you'd like

Be able to have gif's/movies/animated images work in previewer

Additional context

No response

@JustinBacher JustinBacher added the feature New feature request label Jun 23, 2024
@Xerxes-2
Copy link
Contributor

Xerxes-2 commented Jun 24, 2024

You may look into function downscale in yazi-adapter/src/image.rs, and each terminal's own implement in yazi-adapter/src/.
But it will need quite a few changes because now yazi use image's DynamicImage struct to process image, and DynamicImage seems not support animated image.

@sxyazi
Copy link
Owner

sxyazi commented Jun 28, 2024

Yeah I would like to give it a try sometime in the future to see if there's an efficient way to achieve it, it's not a priority for me, but I always welcome any constructive PRs.

Displaying GIFs in the terminal isn't an easy task; we need to consider support for different protocols (AFAIK, kitty and iTerm2 support GIFs, but Sixel doesn't, so we might need to manually split frames for images). There could also be performance problems with how to preload GIF files.

@sxyazi sxyazi mentioned this issue Jul 5, 2024
55 tasks
@sxyazi
Copy link
Owner

sxyazi commented Jul 5, 2024

Tracked in #51, closing in favor of that list

@sxyazi sxyazi closed this as completed Jul 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature request
Projects
None yet
Development

No branches or pull requests

3 participants