-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After opening and editing files with nvim in yazi, the preview is not updated automatically. #129
Comments
This is intentional and a compromise for performance. Currently, only changes in any one of the three elements |
My CPU is Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz and I do not feel any lag in preview when I move between items. Does this performance loss really matter? |
I really want this feature, but I'm not sure how to implement it at the moment. Please consider: On an older machine where the current cursor file is continuously appended to at a millisecond level, how should Yazi handle re-previews? Should it frequently spawn processes for files like videos and PDFs that rely on other tools ( |
Maybe the title is not clear, I mean I open a file with neovim in yazi, edit it explicitly, and quit, the preview is not updated as expected. So just trigger update when I quit and the files is changed, and it is uncessary to supervise the file at other time. |
The preview is triggered by a watcher, which relies on file change notifications from the operating system and is independent of whether the file is opened. If you expect that the preview should only be re-previewed when a file is opened and its content changes, I believe this is not a good way. It would lead to inconsistent preview behavior, meaning that any other method causing a content change would not trigger a re-preview. |
Fixed by #360 |
I'm going to lock this issue because it has been closed for 30 days. ⏳ This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
I have to move the cursor between files to update the preview.
The text was updated successfully, but these errors were encountered: