Skip to content
This repository has been archived by the owner on Apr 10, 2024. It is now read-only.

FeeOracle changes to include gas limit in feeData #10

Closed
2 tasks
P1sar opened this issue Dec 6, 2022 · 0 comments · Fixed by #12
Closed
2 tasks

FeeOracle changes to include gas limit in feeData #10

P1sar opened this issue Dec 6, 2022 · 0 comments · Fixed by #12
Assignees

Comments

@P1sar
Copy link
Collaborator

P1sar commented Dec 6, 2022

Implementation details

Expand endpoint from: /{version}/rate/from/{fromDomainID}/to/{toDomainID}/resourceid/{resourceID}
to something like this:
/{version}/rate/from/{fromDomainID}/to/{toDomainID}/resourceid/{resourceID}/gasLimit/{msgGasLimit}

  • Add this gas limit information to the signed fee data.
  • Do some basic value checks on this parameter

Testing details

  • Expand unit and e2e tests based on changes

Acceptance Criteria

  • Passing unit/e2e tests
  • Working endpoint
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants