Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create ERC721 example application and documents #83

Merged
merged 11 commits into from
Oct 6, 2022
Merged

feat: Create ERC721 example application and documents #83

merged 11 commits into from
Oct 6, 2022

Conversation

enemycnt
Copy link
Contributor

@enemycnt enemycnt commented Oct 3, 2022

Description

Related Issue Or Context

Closes: #80

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@P1sar P1sar requested a review from wainola October 4, 2022 11:28
P1sar
P1sar reviewed Oct 4, 2022
View reviewed changes
examples/erc721-react-example/README.md Outdated
@@ -0,0 +1,12 @@
<p align="center"><a href="https://https://chainsafe.io/"><img width="250" title="Chainbridge UI" src='../../assets/full-logo.png'/></a></p>

## Sygma SDK React Example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect that you will put some more explanations regarding the what method and why you are using

@enemycnt enemycnt marked this pull request as ready for review October 4, 2022 14:54
@enemycnt enemycnt changed the title Create ERC721 example application and documents feat: Create ERC721 example application and documents Oct 5, 2022
@P1sar P1sar merged commit f6ce371 into main Oct 6, 2022
@P1sar P1sar deleted the feat/erc721-example branch October 6, 2022 10:27
@github-actions github-actions bot mentioned this pull request Oct 6, 2022
Merged
This was referenced Nov 7, 2022
Merged
Closed
Merged
Merged
@enemycnt enemycnt mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P1sar P1sar P1sar left review comments

@wainola wainola wainola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create ERC721 example application and documents
3 participants
@enemycnt @P1sar @wainola