Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop - Latest NeoTree is painfully slow. #2943

Closed
synic opened this issue Sep 8, 2015 · 11 comments
Closed

Develop - Latest NeoTree is painfully slow. #2943

synic opened this issue Sep 8, 2015 · 11 comments

Comments

@synic
Copy link
Contributor

synic commented Sep 8, 2015

Expanding and collapsing nodes, searching is now a LOT slower than it used to be.

@synic
Copy link
Contributor Author

synic commented Sep 10, 2015

jaypei/emacs-neotree#126

@synic
Copy link
Contributor Author

synic commented Sep 10, 2015

This appears to be spacemacs specific. It only happens in directories with a lot of git history.

On vanilla emacs with neotree and projectile installed, it is still fast.

EDIT:

It appears to be the combination of neotree and helm-projectile. If I install only these on vanilla emacs, the problem occurs.

@synic
Copy link
Contributor Author

synic commented Sep 13, 2015

This is because spacemacs sets neo-vc-integration to 'face'. From theneotreegithub issues - authorjaypei`:

Yes, this feature is indeed slow, so it is closed by default.
It can speed up when NeoTree support the sub-tree refresh feature.

Setting neo-vc-integration to nil solves the issue for me. Since the author admits the feature is slow, maybe it's more appropriate to make the default nil in spacemacs until this sub-tree refresh feature is available?

@QQism
Copy link

QQism commented Oct 15, 2015

@synic Thanks, you saved my day. To be more specific, in .spacemacs, I need to add

(defun dotspacemacs/config ()
…
(setq neo-vc-integration nil)
)

@josepjaume
Copy link

I'm trying to disable this by putting (setq neo-vc-integration nil) in spacemacs' config but I still see the highlighting and it's still slow. Is anyone having the same issue?

@synic
Copy link
Contributor Author

synic commented Oct 20, 2015

Where are you setting it?

On Tue, Oct 20, 2015 at 5:10 AM Josep Jaume Rey notifications@github.com
wrote:

I'm trying to disable this by putting (setq neo-vc-integration nil) in
spacemacs' config but I still see the highlighting and it's still slow. Is
anyone having the same issue?


Reply to this email directly or view it on GitHub
#2943 (comment)
.

@josepjaume
Copy link

That's odd. It ended up working, but only if I put it first in my config variables, like this:

(defun dotspacemacs/config ()
  "Configuration function.
 This function is called at the very end of Spacemacs initialization after
layers configuration."
  (setq neo-vc-integration nil)

  (setq indent-tabs-mode nil)
  (setq-default tab-width 2)
  (setq evil-shift-width 2)
  (setq js-indent-level 2)
  (setq ruby-indent-level 2)
  (setq html-indent-level 2)

  (setq web-mode-code-indent-offset 2)
  (setq web-mode-css-indent-offset 2)
  (setq web-mode-enable-auto-indentation t)
  (setq web-mode-indent-style 2)
  (setq web-mode-markup-indent-offset 2)
  (setq web-mode-sql-indent-offset 2))
  (setq web-mode-code-indent-offset 2)
  (setq web-mode-markup-indent-offset 2)

  (setq js-indent-level 2)
  (setq css-indent-level 2)
  (setq css-indent-offset 2)
  (setq js2-basic-offset 2)
  (setq js2-indent-switch-body t)
  (setq evil-shift-width 2)

If I put it on the end, right after evil-shift-width, it doesn't work. How strange.

@AlbertGazizov
Copy link

I have the same issue with neotree, setting the neo-vc-integration to nil doesn't help.

@AlbertGazizov
Copy link

placing neo-vc-integration to the user-config helped for me:

(defun dotspacemacs/user-config ()
  (setq neo-vc-integration nil)
   ...
)

@synic
Copy link
Contributor Author

synic commented Nov 20, 2015

So, if I wanted to make a PR, would it just be a documentation update, or change the default, or both?

@joehillen
Copy link
Contributor

👍 for changing the default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants