Add a binding to return from definition in intero mode #10965
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please arrange the keybinding in alphabetical order, and also add it to the documentation. |
magthe
force-pushed
the
intero-return-from-definition
branch
from
7e3a234
to
65f41e1
Compare
Signed-off-by: Magnus Therning <magnus@therning.org>
|
@sdwolfz Done, and I also rebased it onto the latest develop while at it. |
|
Thank you ❤️! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is only a binding for
jump-to-definition(via the spacemacs jump handlers), but there is no binding for returning. It turns out that Intero's jump-to-definition function uses thexrefcross-referencing functions, so adding a return-from-definition is as simple as adding a binding forxref-pop-marker-stack.