Clojure enhancements

[kommen]

1. add a keybinding to open the cider repl history buffer in an evil way (see Clojure enhancements #11431 (comment))
2. evilfy cider-repl-history-mode-map
3. allow to send input to a cider repl in normal mode with RET

[practicalli-johnny]

Yes, this keybinding will make a vast improvement to the usability of the Clojure repl when using Evil

[d12frosted]

Nice! But please add new key bindings to the clojure layer readme file. There is a dedicated section for key bindings. 😸

[kommen]

@d12frosted I discussed with @jr0cket on the Clojurians Slack Spacemacs channel about putting cider-repl-history onto SPC s h instead of , P. I used , P since cider has it on C-c M-p, but I can see making since having it under SPC s since there all the repl commands are. Any opinions on that?

[practicalli-johnny]

We definately need keybindings for Vim Normal mode as it feels very inconsistent changing into vim insert mode just to call the repl history with ,. Its also easy to get confused between , in insert and normal mode. Having to calle SPC SPC cider-repl-history is not great either.

I suggested , s h as it fits in with the mnemonic menu approach: major-mode > cider > history.

Although P is used in the cider package itself, several of the keybindings have changed to conform to the mnemonic approch. If there were other history related keybindings already using P then it would make sense, but I havent seen this convention in Spacemacs.

[kommen]

I've removed the , P key for now seems it seems this needs some more discussion. This still leaves the current way of getting to the history via the cider repl shortcuts, which I just discovered now myself:
in a repl buffer in vim insert mode: , then select history
in a repl buffer in vim normal mode: , , then select history

So I'm not sure if we even should add custom keybindings.

@jr0cket I've also addressed the issue you ran into that RET in vim normal mode didn't evaluate: I had I typo on the patch.

@d12frosted Since this PR doesn't introduce any new keybindings now, I think no changes to the README are needed. The RET keybinding just makes it behave as it should have been and RET is not documented for vim input mode in the repl as well.

[d12frosted]

@kommen makes sense. I've tried to search for any other layer that defines key bindings for navigating the REPL history and didn't find one. But since REPL usually has it's own mode, I don't see a reason to add key bindings under , s.

Anyway, I've cherry-picked this commit into develop, you can safely delete your branch. Thank you 🎉