[haskell] support dynamic completion backend #11550
Conversation
| (`intero (spacemacs-haskell//setup-intero-company)) | ||
| (`dante (spacemacs-haskell//setup-dante-company)) | ||
| (`ghc-mod (spacemacs-haskell//setup-ghc-mod-company)))) | ||
|
|
There was a problem hiding this comment.
This is not an empty line, it's ^L.
There was a problem hiding this comment.
😸I was reading my PR and saw these double-empty lines. Was like - what the line?!
layers/+lang/haskell/packages.el
Outdated
|
|
||
| ;; dante completion backend | ||
| (dante | ||
| :requires company | ||
| :toggle (and (version<= "25" emacs-version) | ||
| (eq haskell-completion-backend 'dante))) | ||
| :toggle (version<= "25" emacs-version)) |
There was a problem hiding this comment.
I haven't checked yet, but it looks rubbish that dante is available only on old Emacs.
There was a problem hiding this comment.
I've checked it. And it is no longer the case. Removed all along.
d12frosted
force-pushed
the
haskell/dir-locals-backend
branch
from
379c59e
to
598299c
Compare
This is no longer represents the real situation as dante requires Emacs >= 25.1
d12frosted
force-pushed
the
haskell/dir-locals-backend
branch
from
598299c
to
83e9392
Compare
|
It would be great to get this merged - it has a fairly trivial merge conflict. I'm working on getting the lsp backend for Haskell working, and this refactoring is definitely desirable first. |
As requested in the review of syl20bnr#11550.
|
I opened #11887, which is based on this. I fixed the merge and removed the form-feed characters, but if this is merged then it should all work cleanly anyway. |
As requested in the review of syl20bnr#11550.
As requested in the review of #11550.
|
The PR: It seems to have been based on this PR. |
|
Oh neat! Thank you both for doing this! |
As requested in the review of syl20bnr#11550.
As requested in the review of syl20bnr/spacemacs#11550.
As requested in the review of syl20bnr#11550.
As requested in the review of syl20bnr#11550.
No description provided.