Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spacemacs-defaults: Added prompt to save a buffer #15297

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

lebensterben
Copy link
Collaborator

@lebensterben lebensterben commented Jan 29, 2022

Added a new kill-buffer-hook that prompt the user to save a buffer
before killing it.

closes #12857

Added a new `kill-buffer-hook` that prompt the user to save a buffer
before killing it.
@lebensterben
Copy link
Collaborator Author

@gutsle @henriquenj
Please pull in this PR and help to test whether this works as you both requested.

@lebensterben lebensterben merged commit d33a1a8 into syl20bnr:develop Feb 9, 2022
@lbutkows
Copy link

lbutkows commented Feb 9, 2022

This change makes difficult to use with treemacs and its collapse feature. Every time the folder is selected, the confirmation to kill the buffer will appear several times.
Buffer "Pfuture-Buffer (/usr/bin/python3 -O ... 3 t)" modified; kill anyway? (y or n) y

lebensterben added a commit that referenced this pull request Feb 9, 2022
eraad pushed a commit to datil/spacemacs that referenced this pull request Jun 10, 2022
Added a new `kill-buffer-hook` that prompt the user to save a buffer
before killing it.
eraad pushed a commit to datil/spacemacs that referenced this pull request Jun 10, 2022
2ynn pushed a commit to 2ynn/spacemacs that referenced this pull request Jun 22, 2022
Added a new `kill-buffer-hook` that prompt the user to save a buffer
before killing it.
2ynn pushed a commit to 2ynn/spacemacs that referenced this pull request Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting a new buffer with changes does not ask for confirmation
2 participants