Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: variable is void: emoji-cheat-sheet-plus-buffer-mode warning #15544

Conversation

dalanicolai
Copy link
Contributor

@dalanicolai dalanicolai commented May 25, 2022

Placing the evilified-state-evilify after the use-package its :init keyword results in a warning at startup that the keymap variable name is void.

This commit fixes it by placing the invocation after the :config keyword.

I have looked through the code base, and I have found that the evilified-state-evilify(-map) macro is used more often after the :init keyword, which seems wrong to me in most cases. Sometimes the invocation, correctly, includes an eval-after-load keyword (like in the edebug layer), but other times it does not (like in the ledger, Chinese, xkcd and several other layers).

Am I missing something? Or are all these invocations used in the wrong place/way?

@smile13241324
Copy link
Collaborator

Hmmm I think there is no higher reasoning behind putting the function call in the init section, I think someone did it wrong and others just copied it. Lets fix this and get rid of these warnings :).

@smile13241324
Copy link
Collaborator

Thank you for contributing to spacemacs 💜, I have cherry picked your commit into develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants