core: byte-compile the "core/libs/" folder when dotspacemacs-byte-compile is t #15696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunlin7
force-pushed
the
core-native-compile-bak
branch
from
49ee363
to
edcb4e8
Compare
|
I prefer not to make haste on byte compiling everything for now. |
sunlin7
force-pushed
the
core-native-compile-bak
branch
from
edcb4e8
to
b94aef2
Compare
|
What about byte-compiling the directory |
|
it's okay to byte compile core/libs. but don't modify any of those files because they are 3rd party packages. |
sunlin7
force-pushed
the
core-native-compile-bak
branch
from
b94aef2
to
c171bd4
Compare
sunlin7
changed the title
|
I had modified the code to byte-compile the Please help review and approve this change. Thanks. |
smile13241324
approved these changes
Aug 11, 2022
|
Thank you all ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently
dotspacemacs-byte-compileistwill only compile serveral files incore/lib/*.After the PR #15692, all files in
core/will be able byte-compile/native-compile.So we'll byte compile the
core/directory whendotspacemacs-byte-compileist.