Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for C# using OmniSharp #500

Closed
wants to merge 1 commit into from

Conversation

@bjarkevad
Copy link
Contributor

@bjarkevad bjarkevad commented Jan 28, 2015

Added initial support for C#, comments et al is of course very welcome.
OmniSharp seems to work reasonably well for the tests I've done on Linux with Mono, but someone should probably try it out with some larger solutions on other system configs.

"mgF" 'omnisharp-navigate-to-solution-file-then-file-member

;; Type info
"mt" 'omnisharp-current-type-information

This comment has been minimized.

@syl20bnr

syl20bnr Jan 29, 2015
Owner

you have a clash here with the test prefix mt

(add-hook 'csharp-mode-hook 'omnisharp-mode)
(use-package omnisharp
:defer t
:config (evil-leader/set-key-for-mode 'csharp-mode

This comment has been minimized.

@syl20bnr

syl20bnr Jan 29, 2015
Owner

Sort the key bindings

This comment has been minimized.

@bjarkevad

bjarkevad Jan 29, 2015
Author Contributor

How do you want the sorting to be?

"mpl" 'omnisharp-add-reference

;; Compile
"mb" 'omnisharp-build-in-emacs ;; Only one compile command so use top-level

This comment has been minimized.

@syl20bnr

syl20bnr Jan 29, 2015
Owner

should be mcc if I'm not mistaken

"mb" 'omnisharp-build-in-emacs ;; Only one compile command so use top-level

;; Code manipulation
"mo" 'omnisharp-auto-complete-overrides

This comment has been minimized.

@syl20bnr

syl20bnr Jan 29, 2015
Owner

not in the conventions but we can keep mo for the user as well as o

@bjarkevad bjarkevad force-pushed the bjarkevad:csharp branch from ffb6acf to fe72381 Jan 29, 2015
@bjarkevad
Copy link
Contributor Author

@bjarkevad bjarkevad commented Jan 29, 2015

I've updated the bindings, but I'm still not really satisfied with the mnemonics - suggestions?

@bjarkevad bjarkevad force-pushed the bjarkevad:csharp branch from fe72381 to 0363824 Jan 31, 2015
@bjarkevad
Copy link
Contributor Author

@bjarkevad bjarkevad commented Jan 31, 2015

Updated bindings again :)

@syl20bnr
Copy link
Owner

@syl20bnr syl20bnr commented Jan 31, 2015

Very nice layer ! ❤️
Thank you !

Cherry-picked into develop you can safely delete your branch.

I made some modifications/improvements:

@syl20bnr syl20bnr closed this Jan 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants