New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for C# using OmniSharp #500

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
2 participants
@bjarkevad
Contributor

bjarkevad commented Jan 28, 2015

Added initial support for C#, comments et al is of course very welcome.
OmniSharp seems to work reasonably well for the tests I've done on Linux with Mono, but someone should probably try it out with some larger solutions on other system configs.

"mgF" 'omnisharp-navigate-to-solution-file-then-file-member
;; Type info
"mt" 'omnisharp-current-type-information

This comment has been minimized.

@syl20bnr

syl20bnr Jan 29, 2015

Owner

you have a clash here with the test prefix mt

(add-hook 'csharp-mode-hook 'omnisharp-mode)
(use-package omnisharp
:defer t
:config (evil-leader/set-key-for-mode 'csharp-mode

This comment has been minimized.

@syl20bnr

syl20bnr Jan 29, 2015

Owner

Sort the key bindings

This comment has been minimized.

@bjarkevad

bjarkevad Jan 29, 2015

Contributor

How do you want the sorting to be?

"mpl" 'omnisharp-add-reference
;; Compile
"mb" 'omnisharp-build-in-emacs ;; Only one compile command so use top-level

This comment has been minimized.

@syl20bnr

syl20bnr Jan 29, 2015

Owner

should be mcc if I'm not mistaken

"mb" 'omnisharp-build-in-emacs ;; Only one compile command so use top-level
;; Code manipulation
"mo" 'omnisharp-auto-complete-overrides

This comment has been minimized.

@syl20bnr

syl20bnr Jan 29, 2015

Owner

not in the conventions but we can keep mo for the user as well as o

@bjarkevad

This comment has been minimized.

Contributor

bjarkevad commented Jan 29, 2015

I've updated the bindings, but I'm still not really satisfied with the mnemonics - suggestions?

@bjarkevad

This comment has been minimized.

Contributor

bjarkevad commented Jan 31, 2015

Updated bindings again :)

@syl20bnr

This comment has been minimized.

Owner

syl20bnr commented Jan 31, 2015

Very nice layer ! ❤️
Thank you !

Cherry-picked into develop you can safely delete your branch.

I made some modifications/improvements:

@syl20bnr syl20bnr closed this Jan 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment