-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proselint layer #5403
Add proselint layer #5403
Conversation
I used a predicate rather than the modes for flycheck b/c I sometimes would like it in all modes (for comments in prog-modes). Uncommenting https://github.com/syl20bnr/spacemacs/pull/5403/files#diff-ca5347cef700e452e57c746cd67fd927R30 will apply it to all text buffers. Also, appending in line 32 https://github.com/syl20bnr/spacemacs/pull/5403/files#diff-ca5347cef700e452e57c746cd67fd927R30 has the effect of it being available but not enabled in all buffers. |
Hmm, maybe I should combine this with writegood-mode: https://github.com/bnbeckwith/writegood-mode |
Stumbled across this today: https://news.ycombinator.com/item?id=11415815 Not the author. :-) |
Interesting, what do you have in mind ? A |
Perhaps that is the way to go. There is a lot to play around with and explore here, with the the other writegood-mode and artbollocks-mode (I think we would want either one or the other). I'm keen on having this implemented as a toggle for minor mode - rather than a major mode (or both) so that I could quickly get feedback for my english in any context. |
Really cool, but I think it should be more general than just a linting layer. See #5996 |
@mkcode Can you rename it to prose layer ? |
Sure. Will do later today. Very glad this getting some attention now 👍 |
Superseded by #6012. |
This layer hooks proselint into flycheck. It defines a toggle on
SPC t P
that turns it on and off. Getting this feedback is emacs is fun.https://github.com/amperser/proselint/
Feedback is appreciated. I do not think that added this as a checker to flycheck is the ideal solution for this, because it can be always enabled like flyspell. When it enabled, it has the bad side effect of canceling the other flycheck checkers until it is toggled off. This works for me as is. Perhaps there is someway use
flycheck-add-next-checker
with a wildcard?