Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proselint layer #5403

Closed
wants to merge 1 commit into from
Closed

Conversation

mkcode
Copy link
Contributor

@mkcode mkcode commented Mar 7, 2016

This layer hooks proselint into flycheck. It defines a toggle on SPC t P that turns it on and off. Getting this feedback is emacs is fun.

https://github.com/amperser/proselint/

Feedback is appreciated. I do not think that added this as a checker to flycheck is the ideal solution for this, because it can be always enabled like flyspell. When it enabled, it has the bad side effect of canceling the other flycheck checkers until it is toggled off. This works for me as is. Perhaps there is someway use flycheck-add-next-checker with a wildcard?

@mkcode
Copy link
Contributor Author

mkcode commented Mar 7, 2016

I used a predicate rather than the modes for flycheck b/c I sometimes would like it in all modes (for comments in prog-modes). Uncommenting https://github.com/syl20bnr/spacemacs/pull/5403/files#diff-ca5347cef700e452e57c746cd67fd927R30 will apply it to all text buffers.

Also, appending in line 32 https://github.com/syl20bnr/spacemacs/pull/5403/files#diff-ca5347cef700e452e57c746cd67fd927R30 has the effect of it being available but not enabled in all buffers.

@mkcode
Copy link
Contributor Author

mkcode commented Mar 8, 2016

Hmm, maybe I should combine this with writegood-mode: https://github.com/bnbeckwith/writegood-mode

@mkcode
Copy link
Contributor Author

mkcode commented Apr 3, 2016

Stumbled across this today: https://news.ycombinator.com/item?id=11415815

Not the author. :-)

@syl20bnr
Copy link
Owner

syl20bnr commented Apr 3, 2016

Interesting, what do you have in mind ? A prose layer ?

@mkcode
Copy link
Contributor Author

mkcode commented Apr 3, 2016

Interesting, what do you have in mind ? A prose layer ?

Perhaps that is the way to go. There is a lot to play around with and explore here, with the the other writegood-mode and artbollocks-mode (I think we would want either one or the other).

I'm keen on having this implemented as a toggle for minor mode - rather than a major mode (or both) so that I could quickly get feedback for my english in any context.

@JAremko
Copy link
Collaborator

JAremko commented May 6, 2016

Really cool, but I think it should be more general than just a linting layer. See #5996

@JAremko
Copy link
Collaborator

JAremko commented May 6, 2016

@mkcode Can you rename it to prose layer ?

@mkcode
Copy link
Contributor Author

mkcode commented May 6, 2016

Can you rename it to prose layer ?

Sure. Will do later today.

Very glad this getting some attention now 👍

@mkcode mkcode mentioned this pull request May 8, 2016
@TheBB
Copy link
Collaborator

TheBB commented May 8, 2016

Superseded by #6012.

@TheBB TheBB closed this May 8, 2016
@mkcode
Copy link
Contributor Author

mkcode commented May 8, 2016

@JAremko - Done in #6012. which replaces this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants