Add natural layer #6012
Add natural layer #6012
Conversation
tried lots of different ways to make anonymous function for the predicate. Non-anonymous function is the only one that seems to work.
layers/prose/packages.el
Outdated
| "Workaround for proselint flycheck checker predicate" | ||
| prose-proselint-enabled) | ||
|
|
||
| (flycheck-define-checker proselint |
There was a problem hiding this comment.
Mb it will better to add this https://github.com/amperser/proselint/blob/master/plugins/flycheck/ to the load path instead of embedding? This way we won't need to maintain the code. But actually it will be even better if we wrap it into a package.
|
It looks like flycheck/flycheck#939 will add proselint. |
Nice find @JAremko. The body of the checker, using json, looks a lot better than what I have in this PR. On the other hand, I'm not happy with the What is your opinion of what we should do? I guess the ideal would be to use the upstream flycheck checker and replace |
@mkcode We can use |
|
@JAremko - Great feedback. 👍 I asked @lunaryorn for instruction for the best way to do this. He should know best. |
This seems to be working well. I would like to be able to use proselint everywhere including for long comments in prog-modes, many of which are already running multiple flycheck checkers that I would also like. This function resets proselint's next-checkers in theory on every new buffer. It allows proselint and the mode defined checkers to all be run.
|
Great idea. Now we need @syl20bnr feedback. Interesting why |
@JAremko - flycheck doesn't check for derived modes: https://github.com/flycheck/flycheck/blob/master/flycheck.el#L1601-L1602 |
|
@mkcode I updated readme to the new standard also renamed and moved the layer. New name fits better if we want to extend it in the future. You can cherrypick it or simply copypasta 😄 mkcode@8dbc974 Also I think you should squash some commits if they aren't particularity interesting.
Too bad. It could'v reduce boilerplate. Thank for pointing out 👍 |
|
@JAremko - cherry picked your commit. What was the motivation to rename as natural mode? Perhaps I missed something in gitter? Also - I'll squash later. I need to get to my real job now... :-) |
|
@mkcode I only renamed the layer. layers on the develop branch are organized in folders. So the layer should go in some category.
No hurry. We are waiting for the flycheck PR to be merged anyway 😉 |
|
If @syl20bnr is ok with the way it is done and the new name/place we'll also need to rename prose to natural in the code - that I forgot to do |
|
Any update? |
|
This layer should be called "language" instead of "natural" since this layer is about language, not nature. |
|
I would call it prose, as language or natural sounds too open, and "prose mode" is self explicative. I would like my bikeshed blue, too :). |
|
It would be nice to have other tools for working with natural language (like LanguageTool #8899) integrated into the layer. That would probably require having to put the different tools behind flags as most of them have got external dependencies, but it would make it a lot easier to add more tools without cluttering things up too much. |
|
What's missing to get this PR merged? Just re-naming sounds doable ;) |
| ;; Reset the proselint next-checkers prop to nil | ||
| (setf (flycheck-checker-get 'proselint 'next-checkers) nil) | ||
| ;; Add the regular mode and predicate checkers for this buffer | ||
| (dolist (checker (flycheck-possibly-suitable-checkers)) |
There was a problem hiding this comment.
flycheck-possibly-suitable-checkers is not available (anymore?) in flycheck 32. I raised a simiilar issue here abingham/flycheck-vale#10 (comment) but it seems that flycheck needs to resolve a long-running issue first.
|
The following PRs changes have been applied to the |
|
I am not sure if integrating proselint is still necessary given that the project looks to be pretty stale, see here https://github.com/amperser/proselint/, last commit is from before 4 years. If it would still be useful, I would volunteer to put it into the spell-checking layer. Though I would prefer to have the build in flycheck package be extracted to its own package and offered to flycheck in general to take the rest of the emacs world with us. But this is something I can do on the way. Let me know if this is still needed. |
|
Looks like this is so old and fragmented we will be better of starting anew with a fresh design for a such a layer. Therefore I will close this PR. |
Adds the beginnings of a prose layer.
Replaces #5403 according to the discussion in #5996.