Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phoenix layer #7192

Closed
wants to merge 2 commits into from
Closed

Add phoenix layer #7192

wants to merge 2 commits into from

Conversation

AgIt0
Copy link
Contributor

@AgIt0 AgIt0 commented Sep 25, 2016

  • Remove elixir's layer project prefix, since it was used only for
    one binding which would be better suited in tests prefix
  • Move alchemist-project-find-test to test prefix
  • Add phoenix prefix and declare bindings

@dongcarl
Copy link

Are there any updates on this?

@syl20bnr
Copy link
Owner

I slowly look at new layer, it will take some time until it lands in the develop branch. In the meantime you can pull this PR locally. Thank you for your patience.

@syl20bnr
Copy link
Owner

I added a convention for frameworks key bindings: 90452329

Should go under SPC m f, if you can update your PR accordingly it would be wonderful!

cc @sdwolfz (as you worked on this at some point).

@sdwolfz
Copy link
Collaborator

sdwolfz commented Jan 18, 2018

Yes, SPC m f sounds great.

- First remove elixir's layer project prefix, since it was used only for
  one binding which would be better suited in tests prefix
- Move `alchemist-project-find-test` to test prefix
- Add `phoenix` prefix and declare bindings
@AgIt0
Copy link
Contributor Author

AgIt0 commented Jan 19, 2018

@syl20bnr updated, looks a bit weird with current defined bindings(most of them are just Find X) but I think that's ok

@AgIt0 AgIt0 force-pushed the add_phoenix branch 2 times, most recently from 6eeb05c to 9787506 Compare January 19, 2018 07:00
@sdwolfz
Copy link
Collaborator

sdwolfz commented Jul 16, 2018

@AgIt0 do you happen to have a sample project I could try this layer on before merging?

@AgIt0
Copy link
Contributor Author

AgIt0 commented Jul 17, 2018

@sdwolfz not an up to date one sadly if you feel like it there is this one that's simple and you can check out https://github.com/AgIt0/newsletter_phoenix
otherwise you can always try with https://github.com/gothinkster/elixir-phoenix-realworld-example-app which is fairly up to date.

Just keep in mind you would need elixir installed and all the packages that are required for the given project otherwise alchemist won't work

@sdwolfz
Copy link
Collaborator

sdwolfz commented Jul 23, 2018

Thank you ❤️!
And congratulations on your first Spacemacs PR 🎉!
Cherry-picked into develop branch, you can safely delete your branch.

@sdwolfz sdwolfz closed this Jul 23, 2018
@AgIt0 AgIt0 deleted the add_phoenix branch July 24, 2018 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants