Keybindings for alchemist-phoenix #8362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to work fine, I haven't noticed any issues with any of the commands. Regarding the prefix, my only comment is that it's slightly cumbersome to type I'm not sure there's a better option, though, and this is functionally complete. |
|
How about the |
|
Sounds good to me, at least I can use two different fingers for it now. |
sdwolfz
changed the title
|
Closing this in favor of #7192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #8327
The choice of the
SPC m nprefix for the keybindings was chosen to be similar with theC-c a none.SPC m pseems to have been chosen to meanproject. Alsoncan be seen as short fornixwhich can be seen as short forphoenix馃槃.If this is not desirable I can switch it to
SPC m porSPC m a p(but this seems a bit to long), or a better suggestion from the audence.