Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove evil-org for worf #9010

Closed
wants to merge 1 commit into from
Closed

Remove evil-org for worf #9010

wants to merge 1 commit into from

Conversation

TheBB
Copy link
Collaborator

@TheBB TheBB commented Jun 1, 2017

This is a repurposing of #1417, the oldest still-open pull request to Spacemacs. It removes evil-org and uses worf for much of its functionality. As a whole, worf has way higher quality and more functionality that we can bind in the future.

  • g{h,j,k,l} still exist and work mostly the same way (a little bit more strict about levels)
  • g] and g[ added, they are pure next/previous operations that don't care about levels
  • Change bindings for inserting headings to be more consistent, both with itself and evil.
    • Previous:
      • o: insert item below
      • O: insert heading below
      • M-o: insert sub-heading below
      • M-t: insert todo sub-heading below
      • T: insert todo heading below
    • New:
      • o: insert item below
      • O: insert item above
      • M-o: insert heading below
      • M-O: insert heading above
      • M-t: insert todo heading below
      • M-T: insert todo heading above
  • Overriding <, > and - is gone. M-h and M-l cover the first two and ,- the latter.
  • Overriding t for org-todo is also gone, moved this to ,TT.
  • Add an org navigation transient state on ,n.

@TheBB
Copy link
Collaborator Author

TheBB commented Jun 1, 2017

Maybe put this on hold pending discussion in #9011

@Stebalien
Copy link
Contributor

FWIW, I've applied this PR locally and find I much prefer worf over evil-org. evil-org to deviates from Evil/Vim in surprising and frustrating ways.

@Stebalien
Copy link
Contributor

Actually, things aren't quite as rosy as I thought. Most importantly, [ and ] are rebound to worf-backward and worf-forward so they can't be typed (WTF?).

Also, o (insert-item-below) can be very aggressive. For example, pressing o in either of the following states:

* Item
  - A
█
* Item
  - A

█

Opens a new item instead of opening a new line:

* Item
  - A
  - |

(in the second case, the cursor goes up).

@Stebalien
Copy link
Contributor

Stebalien commented Jun 4, 2017

On further inspection, I'm pretty sure worf is not intended to be used alongside evil. It adds vim-like features to org-mode but doesn't restrict these features to normal-mode (it doesn't integrate with evil at all).

@TheBB
Copy link
Collaborator Author

TheBB commented Jun 6, 2017

Closing this for #9041

@TheBB TheBB closed this Jun 6, 2017
@TheBB TheBB deleted the worf branch June 6, 2017 13:38
@syl20bnr
Copy link
Owner

syl20bnr commented Jun 6, 2017

On further inspection, I'm pretty sure worf is not intended to be used alongside evil. It adds vim-like features to org-mode but doesn't restrict these features to normal-mode (it doesn't integrate with evil at all).

Indeed this was my principal issue with worf (like with lispy), the implicit states (state changes depending on the position in the buffer) are the opposite philosophy of Vi. I believed I commented on the original PR but I guess that we discussed it on Gitter a few years ago instead.

@syl20bnr
Copy link
Owner

syl20bnr commented Jun 6, 2017

@Stebalien thank you BTW ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants