Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextpage v1.3.8 no longer analyses normal link tags #18

Closed
GoogleCodeExporter opened this issue Mar 17, 2015 · 2 comments
Closed

nextpage v1.3.8 no longer analyses normal link tags #18

GoogleCodeExporter opened this issue Mar 17, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link
Contributor

I frequent a private (for me at least) phpbb board, where nextpage used to work 
great to move to the next page. With v1.3.8, this stopped working.

I have looked into this and found that you commented out checking of 'a' tags 
in line ~495 of nextpage.js - the forum does not assign the 'next' class to the 
links, so detecting the following fails:

<a href="./viewtopic.php?f=5&t=xxxx&st=0&sk=t&sd=a&start=30">Next</a>

Restoring this functionality allows me to move around threads again.

When I enabled debugging, I found that nextpage.debug.show was throwing errors 
- 'TypeError: can't convert Proxy to string' - wrapping the 
'dirResult.push([prop, obj[prop]].join(': '));' line in a try/catch worked 
around this.

Original issue reported on code.google.com by OmegaP...@gmail.com on 16 Jan 2014 at 7:36

@GoogleCodeExporter
Copy link
Contributor Author

Thanks for the bug report, the major bug you mentioned is fixed in 1.3.9.

About the debugging error, I will look into it later.

Original comment by syl...@gmail.com on 10 Feb 2014 at 1:22

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Contributor Author

Cheers :)

Original comment by OmegaP...@gmail.com on 10 Feb 2014 at 10:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant