Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate HD Wallets from Private Key wallets #221

Closed
decentraliser opened this issue Apr 10, 2020 · 12 comments · Fixed by #516
Closed

Separate HD Wallets from Private Key wallets #221

decentraliser opened this issue Apr 10, 2020 · 12 comments · Fixed by #516
Assignees
@evias @bassemmagdy
Labels
enhancement New feature or request story-13 13 Story Points
Projects
Symbol Desktop Wallet
Milestone
Release Candidate

Comments

@decentraliser
Copy link
Contributor

Import account page:

  • Add a link around "more options are being worked on" to import a private key

Account creation:

  • It should be possible to create a profile with a private key

Wallets import

  • When using an HD profile, it should not be possible to import a private key
  • When using a private key profile, it should not be possible to import a private key nor a wallet
@JeRaytheon
Copy link
Contributor

JeRaytheon commented Apr 10, 2020 •
edited

image

image

image

The entrance and importer pages, and compatible with profile
like this , is ok? or other better methods ？

@evias evias added enhancement New feature or request story-8 8 Story Points labels Apr 10, 2020
@evias evias added this to the Release Candidate milestone Apr 10, 2020
@ABCDEFLY
Copy link

ABCDEFLY commented Apr 14, 2020 •
edited

english

New pages for pravite keys enter. should need to determine whether the separation interaction is feasible ? @decentraliser @evias

@ABCDEFLY
Copy link

chinese

@decentraliser
Copy link
Contributor Author

We'll need Jabo opinion about that

@decentraliser
Copy link
Contributor Author

New pages for pravite keys enter should need to determine whether the separation
@ABCDEFLY I'm sorry I'm not sure that I understand the question, could you please reformulate?

@decentraliser
Copy link
Contributor Author

I'm not sure about the "new profile" switch above the form
I like it but I think it will be confusing

image

@ABCDEFLY
Copy link

ABCDEFLY commented Apr 14, 2020 •
edited

yes, maybe some thing better.
I want people to have the freedom to have multiple profiles to manage their private keys while reducing the pages

@evias
Copy link
Contributor

evias commented Apr 14, 2020

Why is there a switch about "New Profile"

  1. Please apply the proposed screens as a new form (FormCreatePrivateKeyWallet)
  2. Use this form in a new screen of the create-account page.
  3. Re-use the same form in a new screen of the import-account page.
  4. Adapt the FormSubWalletCreation to only permit:
    4.1 Create by private key only in case of Private key profile
    4.2 Create child only in case of HD profile.

@ABCDEFLY
Copy link

prototype
Make full use of old screens，Wireframes are words that need to be modified

@ABCDEFLY
Copy link

Remove the creation of private keys, standardize the entry, and unify the import style.
画板 – 4

vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue Apr 17, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fix symbol#221 )
515e397
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue Apr 17, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fix symbol#221 )
26a5ab5
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue Apr 17, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fix symbol#221 )
7c7a3fd
@David0817 David0817 mentioned this issue Apr 18, 2020
Closed
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue Apr 21, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fix symbol#221 )
2c3e50f
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue Apr 21, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fix symbol#221 )
13f100e
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue Apr 23, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fix symbol#221 )
5eb1ff4
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue May 15, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fixes symbol#221 )
e438a2b
@evias evias added this to In stage in Symbol Desktop Wallet May 26, 2020
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue May 27, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fixes symbol#221 )
a4b41c4
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue May 29, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fixes symbol#221 )
e3c2834
@vincent-lee90 vincent-lee90 mentioned this issue May 29, 2020
Closed
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue May 29, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fixes symbol#221 )
9f3bcc1
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue May 29, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fixes symbol#221 )
9026212
@evias evias moved this from In stage to In progress in Symbol Desktop Wallet Jun 1, 2020
@evias evias moved this from In progress to In stage / "Sprint backlog" in Symbol Desktop Wallet Jun 8, 2020
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue Jun 12, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fixes symbol#221 )
4126021
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue Jun 12, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fixes symbol#221 )
632ee39
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue Jun 15, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fixes symbol#221 )
8b85a53
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue Jun 22, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fixes symbol#221 )
4aa1669
vincent-lee90 added a commit to JeRaytheon/symbol-desktop-wallet that referenced this issue Jul 12, 2020
@vincent-lee90
Separate HD Wallets from Private Key wallets( fixes symbol#221 )
fa24a0d
@evias evias moved this from Priority to Product backlog in Symbol Desktop Wallet Jul 15, 2020
@evias evias moved this from Product backlog to Priority in Symbol Desktop Wallet Jul 15, 2020
@evias evias moved this from Priority to In progress in Symbol Desktop Wallet Jul 16, 2020
@bassemmagdy bassemmagdy moved this from In progress to Priority in Symbol Desktop Wallet Aug 24, 2020
@bassemmagdy bassemmagdy moved this from Priority to In progress in Symbol Desktop Wallet Sep 11, 2020
@bassemmagdy bassemmagdy added story-13 13 Story Points and removed story-8 8 Story Points labels Sep 15, 2020
@jabo38
Copy link

jabo38 commented Sep 15, 2020

I don't think we need a "create private key" section. Only "import private key". People that have private keys from this way or that way can have a place to import them. They will already be backed up too that way.

But if anybody is "creating" anything, they should just creating mnemonics. This way the desktop app and mobile app are following the same wallet creation pathway and will be cross-compatible.

If we allow people to create a private key wallet on desktop, there won't be anyway for them to import that into the mobile app.

@jabo38
Copy link

jabo38 commented Sep 15, 2020

If the community requests create private key wallets later, we can look into that. But almost all blockchain wallets have switched to mnemonic only wallets.

@bassemmagdy bassemmagdy mentioned this issue Sep 28, 2020
Merged
@bassemmagdy bassemmagdy moved this from In progress to Review in progress in Symbol Desktop Wallet Sep 30, 2020
Symbol Desktop Wallet automation moved this from Review in progress to Done Sep 30, 2020
evias pushed a commit that referenced this issue Sep 30, 2020
@bassemmagdy
Seprate wallets fixes #221 (#516)
635ffa0 
* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* seperate hd-wallet from private key wallets

Co-authored-by: Baha <bahadir.yilmaz@nem.software>
evias added a commit that referenced this issue Sep 30, 2020
@bassemmagdy @yilmazbahadir
v0.13.1: Fixed Network Compatibility for v0.10.x (#520)
8f56c2f 
* Creating new version 0.13.1

* Mnemonic passphrase QR Code export option added on profile creation (fixes #106)

* Profile creation mnemonic passphrase backup tips design is enhanced (fixes #106)

* Linting (#106)

* i18n keys typo fix

* (fix) Using temporarily stored password to produce MnemonicQR now, fixes #106

* SignerSelector is added to namespace -> create an alias form and SignerFilter is added to namespaces list (fixes #480)

* Create an alias form default signer selected

* index.html and icon paths are fixed(for linux, windows), fixes (#457)

* Display current rental fee enhancement #356 (#489)

* display current rental fee in mosaic and namespace creation

* adding rental fees to form for creating/extending namespaces and mosaics > resolves #356 #357

* linting

* fixing tests for travis build

* Update TransactionView.ts

* refactor componenets + adding fees to confirmed transaction modal #356 #357 #488

* avoiding confirmed transaction in getting rental fees to solve conflict from aggregate transaction pr + solving some eslint warnings

* updates

* fixing mosaic details doesn't load in transaction confirmation modal while creating new mosaics

* bugfix namespace transaction doesn't load details #357 #488 #356

* resolve conflicts

* Creating new version 0.13.1

Co-authored-by: travis@localhost <travis@localhost>

* show expired mosaics in transaction details fixes #279 (#496)

* Gh249 qr codes and uri handling (#510)

* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* CosignatureQR export/import feature implemented, fixes #249, #504

* Alphabetically sorted the keys in language files, fixes #249, #504

Co-authored-by: Baha <bahadir.yilmaz@nem.software>
Co-authored-by: Grégory Saive <greg@evias.be>

* Bugfix/capitalized label (#518)

* rebase

* fixes #501

* allow msg only transactions without mosaics #474 (#494)

* allow msg only transactions without mosaics #474

* Upgraded SDK to 0.20.8 alpha ; Merged in 0.10 compatibility commits

* Creating new version 0.13.1

Co-authored-by: Gregory Saive <greg@evias.be>
Co-authored-by: travis@localhost <travis@localhost>

* Csv export (#507)

* utransform data and ui updates for csv export fixes #416

* linting

* fix travis build

* Seprate wallets fixes #221 (#516)

* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* seperate hd-wallet from private key wallets

Co-authored-by: Baha <bahadir.yilmaz@nem.software>

* Added database migrations for v0.10.x Network compatibility (#519)

* Upgraded SDK to 0.21 ; HD & QR to 0.13 ; Added database migrations

* Update profile migration (BREAKING)

* Fixed linter issues

* Gh509 transaction uri import export (#517)

* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* CosignatureQR export/import feature implemented, fixes #249, #504

* Alphabetically sorted the keys in language files, fixes #249, #504

* Transaction URI import & export feature implemented, fixes #509

* package-lock.json update

Co-authored-by: Baha <bahadir.yilmaz@nem.software>

Co-authored-by: travis@localhost <travis@localhost>
Co-authored-by: Baha <bahadir.yilmaz@nem.software>
Co-authored-by: Bassem <bassem.magdyy94@gmail.com>
Co-authored-by: yilmazbahadir <yilmazbahadir@gmail.com>
@jabo38 jabo38 mentioned this issue Oct 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evias evias

@bassemmagdy bassemmagdy

Labels
enhancement New feature or request story-13 13 Story Points
Projects
Symbol Desktop Wallet
  
Done
Milestone
Release Candidate
6 participants
@evias @bassemmagdy @jabo38 @ABCDEFLY @decentraliser @JeRaytheon