New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TransactionURI import & export feature #509
Comments
As discussed with @evias, following changes has been applied to the design:
@jabo38 could you also review and share your thoughts on this? Following are the screenshots of the implementation: |
I don't understand why the export transaction URI is on the send screen. In that scenario, I'm guessing the transaction still needs to be signed. So why would somebody take a transaction URI that they haven't signed, then import it into another wallet where they would have to sign it. I think it makes more sense to put it in the screen where a person has already entered their password and are signing the tx. So in theory, I would going to the confirm screen, entering my password, but instead of clicking "confirm", I would click on a drop down arrow on the confirm screen that would give the option to export tx as a URI. And since this is a very advanced feature, but on a page where 99% of people won't be doing something advanced, it would be nice if they were clicking on signed tx as URI, that they were given a way to have an explainer of what they were doing or why they would want to do it. As for import tx URI, it doesn't look bad where it is in the screen shots and I don't have any suggestions how to improve it. |
I think URI Scheme Library doesn't support representing already signed transactions. Because it says "URI Scheme library to serve Symbol transactions ready to be signed." in the library repo (https://github.com/nemtech/symbol-uri-scheme). |
* QR Code import feature implemented (fixes #249) * Missing Copyright notices fixed * CosignatureQR export/import feature implemented, fixes #249, #504 * Alphabetically sorted the keys in language files, fixes #249, #504 * Transaction URI import & export feature implemented, fixes #509 * package-lock.json update Co-authored-by: Baha <bahadir.yilmaz@nem.software>
* Creating new version 0.13.1 * Mnemonic passphrase QR Code export option added on profile creation (fixes #106) * Profile creation mnemonic passphrase backup tips design is enhanced (fixes #106) * Linting (#106) * i18n keys typo fix * (fix) Using temporarily stored password to produce MnemonicQR now, fixes #106 * SignerSelector is added to namespace -> create an alias form and SignerFilter is added to namespaces list (fixes #480) * Create an alias form default signer selected * index.html and icon paths are fixed(for linux, windows), fixes (#457) * Display current rental fee enhancement #356 (#489) * display current rental fee in mosaic and namespace creation * adding rental fees to form for creating/extending namespaces and mosaics > resolves #356 #357 * linting * fixing tests for travis build * Update TransactionView.ts * refactor componenets + adding fees to confirmed transaction modal #356 #357 #488 * avoiding confirmed transaction in getting rental fees to solve conflict from aggregate transaction pr + solving some eslint warnings * updates * fixing mosaic details doesn't load in transaction confirmation modal while creating new mosaics * bugfix namespace transaction doesn't load details #357 #488 #356 * resolve conflicts * Creating new version 0.13.1 Co-authored-by: travis@localhost <travis@localhost> * show expired mosaics in transaction details fixes #279 (#496) * Gh249 qr codes and uri handling (#510) * QR Code import feature implemented (fixes #249) * Missing Copyright notices fixed * CosignatureQR export/import feature implemented, fixes #249, #504 * Alphabetically sorted the keys in language files, fixes #249, #504 Co-authored-by: Baha <bahadir.yilmaz@nem.software> Co-authored-by: Grégory Saive <greg@evias.be> * Bugfix/capitalized label (#518) * rebase * fixes #501 * allow msg only transactions without mosaics #474 (#494) * allow msg only transactions without mosaics #474 * Upgraded SDK to 0.20.8 alpha ; Merged in 0.10 compatibility commits * Creating new version 0.13.1 Co-authored-by: Gregory Saive <greg@evias.be> Co-authored-by: travis@localhost <travis@localhost> * Csv export (#507) * utransform data and ui updates for csv export fixes #416 * linting * fix travis build * Seprate wallets fixes #221 (#516) * QR Code import feature implemented (fixes #249) * Missing Copyright notices fixed * seperate hd-wallet from private key wallets Co-authored-by: Baha <bahadir.yilmaz@nem.software> * Added database migrations for v0.10.x Network compatibility (#519) * Upgraded SDK to 0.21 ; HD & QR to 0.13 ; Added database migrations * Update profile migration (BREAKING) * Fixed linter issues * Gh509 transaction uri import export (#517) * QR Code import feature implemented (fixes #249) * Missing Copyright notices fixed * CosignatureQR export/import feature implemented, fixes #249, #504 * Alphabetically sorted the keys in language files, fixes #249, #504 * Transaction URI import & export feature implemented, fixes #509 * package-lock.json update Co-authored-by: Baha <bahadir.yilmaz@nem.software> Co-authored-by: travis@localhost <travis@localhost> Co-authored-by: Baha <bahadir.yilmaz@nem.software> Co-authored-by: Bassem <bassem.magdyy94@gmail.com> Co-authored-by: yilmazbahadir <yilmazbahadir@gmail.com>
User should be able to export/import a transaction as a TransactionURI (see https://github.com/nemtech/symbol-uri-scheme ).
TransactionURI Export: On the transfer page, the send button should be changed into a dropdown action button (with preserving the default send button behaviour intact), as an optional action export to TransactionURI should be clicked and URI should be shown on a modal page to copy.
TransactionURI Import: Can be a modal page being opened by a Top bar menu item or can be another tab to the dashboard transfer tabs
The text was updated successfully, but these errors were encountered: