Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransactionURI import & export feature #509

Closed
yilmazbahadir opened this issue Sep 7, 2020 · 3 comments · Fixed by #517
Closed

TransactionURI import & export feature #509

yilmazbahadir opened this issue Sep 7, 2020 · 3 comments · Fixed by #517
Assignees
Labels
enhancement New feature or request story-8 8 Story Points

Comments

@yilmazbahadir
Copy link
Contributor

User should be able to export/import a transaction as a TransactionURI (see https://github.com/nemtech/symbol-uri-scheme ).

  • TransactionURI Export: On the transfer page, the send button should be changed into a dropdown action button (with preserving the default send button behaviour intact), as an optional action export to TransactionURI should be clicked and URI should be shown on a modal page to copy.

  • TransactionURI Import: Can be a modal page being opened by a Top bar menu item or can be another tab to the dashboard transfer tabs

@yilmazbahadir yilmazbahadir self-assigned this Sep 7, 2020
@yilmazbahadir yilmazbahadir added enhancement New feature or request priority story-8 8 Story Points labels Sep 7, 2020
@yilmazbahadir yilmazbahadir added this to Product backlog in Symbol Desktop Wallet via automation Sep 7, 2020
@yilmazbahadir yilmazbahadir moved this from Product backlog to Priority in Symbol Desktop Wallet Sep 7, 2020
@yilmazbahadir yilmazbahadir moved this from Priority to In progress in Symbol Desktop Wallet Sep 21, 2020
@yilmazbahadir
Copy link
Contributor Author

As discussed with @evias, following changes has been applied to the design:

  • Instead of modal export transaction URI page, transaction URI is shown on the bottom of the transfer page and it gets updated live as the user fills the details.
  • When the user hovers over the link icon a Tooltip is shown and a Poptip is shown for the full version of the transaction URI when user clicks the shortened transaction URI. A copy button for the user to easily copy the transaction URI.

@jabo38 could you also review and share your thoughts on this?

Following are the screenshots of the implementation:

Screenshot 2020-09-25 at 20 35 01

Screenshot 2020-09-25 at 21 02 30
Screenshot 2020-09-25 at 21 02 43

Screenshot 2020-09-25 at 20 35 24

@jabo38
Copy link

jabo38 commented Sep 25, 2020

I don't understand why the export transaction URI is on the send screen. In that scenario, I'm guessing the transaction still needs to be signed. So why would somebody take a transaction URI that they haven't signed, then import it into another wallet where they would have to sign it.

I think it makes more sense to put it in the screen where a person has already entered their password and are signing the tx.

So in theory, I would going to the confirm screen, entering my password, but instead of clicking "confirm", I would click on a drop down arrow on the confirm screen that would give the option to export tx as a URI.

image

And since this is a very advanced feature, but on a page where 99% of people won't be doing something advanced, it would be nice if they were clicking on signed tx as URI, that they were given a way to have an explainer of what they were doing or why they would want to do it.

image

As for import tx URI, it doesn't look bad where it is in the screen shots and I don't have any suggestions how to improve it.

@yilmazbahadir
Copy link
Contributor Author

I think URI Scheme Library doesn't support representing already signed transactions.

Because it says "URI Scheme library to serve Symbol transactions ready to be signed." in the library repo (https://github.com/nemtech/symbol-uri-scheme).

yilmazbahadir pushed a commit to yilmazbahadir/symbol-desktop-wallet that referenced this issue Sep 29, 2020
@yilmazbahadir yilmazbahadir moved this from In progress to Review in progress in Symbol Desktop Wallet Sep 29, 2020
Symbol Desktop Wallet automation moved this from Review in progress to Done Sep 30, 2020
evias pushed a commit that referenced this issue Sep 30, 2020
* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* CosignatureQR export/import feature implemented, fixes #249, #504

* Alphabetically sorted the keys in language files, fixes #249, #504

* Transaction URI import & export feature implemented, fixes #509

* package-lock.json update

Co-authored-by: Baha <bahadir.yilmaz@nem.software>
evias added a commit that referenced this issue Sep 30, 2020
* Creating new version 0.13.1

* Mnemonic passphrase QR Code export option added on profile creation (fixes #106)

* Profile creation mnemonic passphrase backup tips design is enhanced (fixes #106)

* Linting (#106)

* i18n keys typo fix

* (fix) Using temporarily stored password to produce MnemonicQR now, fixes #106

* SignerSelector is added to namespace -> create an alias form and SignerFilter is added to namespaces list (fixes #480)

* Create an alias form default signer selected

* index.html and icon paths are fixed(for linux, windows), fixes (#457)

* Display current rental fee enhancement #356 (#489)

* display current rental fee in mosaic and namespace creation

* adding rental fees to form for creating/extending namespaces and mosaics > resolves #356 #357

* linting

* fixing tests for travis build

* Update TransactionView.ts

* refactor componenets + adding fees to confirmed transaction modal #356 #357 #488

* avoiding confirmed transaction in getting rental fees to solve conflict from aggregate transaction pr + solving some eslint warnings

* updates

* fixing mosaic details doesn't load in transaction confirmation modal while creating new mosaics

* bugfix namespace transaction doesn't load details #357 #488 #356

* resolve conflicts

* Creating new version 0.13.1

Co-authored-by: travis@localhost <travis@localhost>

* show expired mosaics in transaction details fixes #279 (#496)

* Gh249 qr codes and uri handling (#510)

* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* CosignatureQR export/import feature implemented, fixes #249, #504

* Alphabetically sorted the keys in language files, fixes #249, #504

Co-authored-by: Baha <bahadir.yilmaz@nem.software>
Co-authored-by: Grégory Saive <greg@evias.be>

* Bugfix/capitalized label (#518)

* rebase

* fixes #501

* allow msg only transactions without mosaics #474 (#494)

* allow msg only transactions without mosaics #474

* Upgraded SDK to 0.20.8 alpha ; Merged in 0.10 compatibility commits

* Creating new version 0.13.1

Co-authored-by: Gregory Saive <greg@evias.be>
Co-authored-by: travis@localhost <travis@localhost>

* Csv export (#507)

* utransform data and ui updates for csv export fixes #416

* linting

* fix travis build

* Seprate wallets fixes #221 (#516)

* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* seperate hd-wallet from private key wallets

Co-authored-by: Baha <bahadir.yilmaz@nem.software>

* Added database migrations for v0.10.x Network compatibility (#519)

* Upgraded SDK to 0.21 ; HD & QR to 0.13 ; Added database migrations

* Update profile migration (BREAKING)

* Fixed linter issues

* Gh509 transaction uri import export (#517)

* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* CosignatureQR export/import feature implemented, fixes #249, #504

* Alphabetically sorted the keys in language files, fixes #249, #504

* Transaction URI import & export feature implemented, fixes #509

* package-lock.json update

Co-authored-by: Baha <bahadir.yilmaz@nem.software>

Co-authored-by: travis@localhost <travis@localhost>
Co-authored-by: Baha <bahadir.yilmaz@nem.software>
Co-authored-by: Bassem <bassem.magdyy94@gmail.com>
Co-authored-by: yilmazbahadir <yilmazbahadir@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request story-8 8 Story Points
Projects
Development

Successfully merging a pull request may close this issue.

2 participants