Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CosignatureQR Export Feature #504

Closed
yilmazbahadir opened this issue Sep 1, 2020 · 0 comments
Closed

CosignatureQR Export Feature #504

yilmazbahadir opened this issue Sep 1, 2020 · 0 comments
Assignees
@yilmazbahadir
Labels
enhancement New feature or request story-5 5 Story Points
Projects
Symbol Desktop Wallet

Comments

@yilmazbahadir
Copy link
Contributor

CosignatureQR Export feature is missing in the wallet-desktop app at the moment. On the transaction info page if the type is AggregateTransaction there should be a button to export the QR Code. The use case here is the QR Code will be sent to the other cosigner for this convenience to sign it easily.
@yilmazbahadir yilmazbahadir self-assigned this Sep 1, 2020
@yilmazbahadir yilmazbahadir added enhancement New feature or request story-5 5 Story Points labels Sep 1, 2020
@yilmazbahadir yilmazbahadir added this to Priority in Symbol Desktop Wallet Sep 1, 2020
@yilmazbahadir yilmazbahadir mentioned this issue Sep 1, 2020
Closed
@yilmazbahadir yilmazbahadir moved this from Priority to In progress in Symbol Desktop Wallet Sep 14, 2020
yilmazbahadir pushed a commit to yilmazbahadir/symbol-desktop-wallet that referenced this issue Sep 18, 2020
CosignatureQR export/import feature implemented, fixes symbol#249, sy…
2d095b1 
…mbol#504
yilmazbahadir pushed a commit to yilmazbahadir/symbol-desktop-wallet that referenced this issue Sep 18, 2020
Alphabetically sorted the keys in language files, fixes symbol#249, s…
145d5a2 
…ymbol#504
@yilmazbahadir yilmazbahadir moved this from In progress to Review in progress in Symbol Desktop Wallet Sep 20, 2020
yilmazbahadir pushed a commit to yilmazbahadir/symbol-desktop-wallet that referenced this issue Sep 28, 2020
CosignatureQR export/import feature implemented, fixes symbol#249, sy…
6a061c9 
…mbol#504
yilmazbahadir pushed a commit to yilmazbahadir/symbol-desktop-wallet that referenced this issue Sep 28, 2020
Alphabetically sorted the keys in language files, fixes symbol#249, s…
d7c207b 
…ymbol#504
evias added a commit that referenced this issue Sep 30, 2020
@yilmazbahadir
Gh249 qr codes and uri handling (#510)
15cd277 
* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* CosignatureQR export/import feature implemented, fixes #249, #504

* Alphabetically sorted the keys in language files, fixes #249, #504

Co-authored-by: Baha <bahadir.yilmaz@nem.software>
Co-authored-by: Grégory Saive <greg@evias.be>
evias pushed a commit that referenced this issue Sep 30, 2020
@yilmazbahadir
Gh509 transaction uri import export (#517)
3ef0371 
* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* CosignatureQR export/import feature implemented, fixes #249, #504

* Alphabetically sorted the keys in language files, fixes #249, #504

* Transaction URI import & export feature implemented, fixes #509

* package-lock.json update

Co-authored-by: Baha <bahadir.yilmaz@nem.software>
evias added a commit that referenced this issue Sep 30, 2020
@bassemmagdy @yilmazbahadir
v0.13.1: Fixed Network Compatibility for v0.10.x (#520)
8f56c2f 
* Creating new version 0.13.1

* Mnemonic passphrase QR Code export option added on profile creation (fixes #106)

* Profile creation mnemonic passphrase backup tips design is enhanced (fixes #106)

* Linting (#106)

* i18n keys typo fix

* (fix) Using temporarily stored password to produce MnemonicQR now, fixes #106

* SignerSelector is added to namespace -> create an alias form and SignerFilter is added to namespaces list (fixes #480)

* Create an alias form default signer selected

* index.html and icon paths are fixed(for linux, windows), fixes (#457)

* Display current rental fee enhancement #356 (#489)

* display current rental fee in mosaic and namespace creation

* adding rental fees to form for creating/extending namespaces and mosaics > resolves #356 #357

* linting

* fixing tests for travis build

* Update TransactionView.ts

* refactor componenets + adding fees to confirmed transaction modal #356 #357 #488

* avoiding confirmed transaction in getting rental fees to solve conflict from aggregate transaction pr + solving some eslint warnings

* updates

* fixing mosaic details doesn't load in transaction confirmation modal while creating new mosaics

* bugfix namespace transaction doesn't load details #357 #488 #356

* resolve conflicts

* Creating new version 0.13.1

Co-authored-by: travis@localhost <travis@localhost>

* show expired mosaics in transaction details fixes #279 (#496)

* Gh249 qr codes and uri handling (#510)

* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* CosignatureQR export/import feature implemented, fixes #249, #504

* Alphabetically sorted the keys in language files, fixes #249, #504

Co-authored-by: Baha <bahadir.yilmaz@nem.software>
Co-authored-by: Grégory Saive <greg@evias.be>

* Bugfix/capitalized label (#518)

* rebase

* fixes #501

* allow msg only transactions without mosaics #474 (#494)

* allow msg only transactions without mosaics #474

* Upgraded SDK to 0.20.8 alpha ; Merged in 0.10 compatibility commits

* Creating new version 0.13.1

Co-authored-by: Gregory Saive <greg@evias.be>
Co-authored-by: travis@localhost <travis@localhost>

* Csv export (#507)

* utransform data and ui updates for csv export fixes #416

* linting

* fix travis build

* Seprate wallets fixes #221 (#516)

* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* seperate hd-wallet from private key wallets

Co-authored-by: Baha <bahadir.yilmaz@nem.software>

* Added database migrations for v0.10.x Network compatibility (#519)

* Upgraded SDK to 0.21 ; HD & QR to 0.13 ; Added database migrations

* Update profile migration (BREAKING)

* Fixed linter issues

* Gh509 transaction uri import export (#517)

* QR Code import feature implemented (fixes #249)

* Missing Copyright notices fixed

* CosignatureQR export/import feature implemented, fixes #249, #504

* Alphabetically sorted the keys in language files, fixes #249, #504

* Transaction URI import & export feature implemented, fixes #509

* package-lock.json update

Co-authored-by: Baha <bahadir.yilmaz@nem.software>

Co-authored-by: travis@localhost <travis@localhost>
Co-authored-by: Baha <bahadir.yilmaz@nem.software>
Co-authored-by: Bassem <bassem.magdyy94@gmail.com>
Co-authored-by: yilmazbahadir <yilmazbahadir@gmail.com>
@yilmazbahadir yilmazbahadir moved this from Review in progress to Reviewer approved in Symbol Desktop Wallet Oct 6, 2020
@yilmazbahadir yilmazbahadir moved this from Reviewer approved to Done in Symbol Desktop Wallet Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yilmazbahadir yilmazbahadir

Labels
enhancement New feature or request story-5 5 Story Points
Projects
Symbol Desktop Wallet
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yilmazbahadir