Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tracker for main contributor to footer #748

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Added tracker for main contributor to footer #748

wants to merge 11 commits into from

Conversation

mjh316
Copy link

@mjh316 mjh316 commented Dec 31, 2021

Modified gitstamp.py and footer.html as mentioned in #746 to keep track of the main contributor for each page on the footer.

@netlify
Copy link

netlify bot commented Dec 31, 2021

✔️ Deploy Preview for nemtech ready!
Built without sensitive environment variables

🔨 Explore the source changes: 0bd56bf

🔍 Inspect the deploy log: https://app.netlify.com/sites/nemtech/deploys/61cf5e7dd877d100095a7a95

😎 Browse the preview: https://deploy-preview-748--nemtech.netlify.app

@segfaultxavi segfaultxavi linked an issue Dec 31, 2021 that may be closed by this pull request
2 tasks
@segfaultxavi segfaultxavi self-requested a review December 31, 2021 10:23
Copy link
Collaborator

@segfaultxavi segfaultxavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU very much for submitting this!

However, can you fix this problem? The Netlify preview is failing because of this:

5:19:14 AM: Extension error (gitstamp):
5:19:14 AM: Handler <function page_context_handler at 0x7f31ce49f3a0> for event 'html-page-context' threw an exception (exception: not enough values to unpack (expected 2, got 1))

@mjh316
Copy link
Author

mjh316 commented Dec 31, 2021

I've modified the code to handle the case where git.shortlog returns an empty string, but this always happens. Is there any specific configuration that's different for the netlify build vs local besides GITHUB_TOKEN being provided that would be related?

@mjh316
Copy link
Author

mjh316 commented Jan 2, 2022

Error seems to occur due to lack of .git folder in deployment. Will have to try another method besides using the global g git.Repo object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show "Main contributor" besides "Last contributor" on every page
2 participants