add optional local_parser_constants to Parser #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I've run clang-format and found that the code formatting is good. Thanks for fixing the formatting. |
- add parse_julia function that uses "im" for I - implemented as described in symengine#1462
rikardn
approved these changes
Apr 12, 2021
isuruf
reviewed
Apr 12, 2021
isuruf
reviewed
Apr 12, 2021
isuruf
reviewed
Apr 14, 2021
isuruf
reviewed
Apr 14, 2021
symengine/parser.h
Outdated
| @@ -7,6 +7,7 @@ namespace SymEngine | |||
| { | |||
|
|
|||
| RCP<const Basic> parse(const std::string &s, bool convert_xor = true); | |||
| RCP<const Basic> parse_julia(const std::string &s, bool convert_xor = true); | |||
There was a problem hiding this comment.
I don't think we need a special function for julia, but we should add a function like basic_parse2 to expose sending local_parser_constants to parse C++ function.
There was a problem hiding this comment.
I don't see a string->basic map type in the cwrapper, should I add a CMapStrBasic for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_juliafunction that uses "im" forI