ChainRouter: propagate match() call instead of mocking Request and calling matchRequest()

[sustmi]

Deprecates PR #147

[dbu]

thanks for this pull request. i am however afraid that this could lead to unexpected behaviour changes. see for example #151.

@sustmi @ pk16011990 is the problem you encounter not solved when you use the matchRequest method with a request that you create correctly?

[sustmi]

@dbu , OK lets forget about fixing propagating match().
Still, I insist that the bug is in ChainRouter and not Symfony.

UrlMatcherInterface::match() takes pathinfo as parameter and not URL.
You should not pass pathinfo into Request::create(), because it expects URI.
According to RFC-3986 URI //g means g is hostname ie. pathinfo is /.

Request::create() is correct, but ChainRouter is not using it right.

These commits try to fix the behaviour: https://github.com/sustmi/Routing/compare/master...fix-matching-pathinfo?expand=1

[lsmith77]

maybe a safer approach would be to set a "dummy host" in this edge case to prevent the // being misinterpreted?

[dbu]

@sustmi okay, sorry for letting this sit around so long. i propose we add handling for the specific case of path starting with // and in that case add //host from $_REQUEST if set, //localhost otherwise. that should avoid the edge case, right? can you do a pull request @sustmi ?

[sustmi]

I don't understand. If you have Request instance, you don't need to fake it. Or do you really mean $_REQUEST superglobal?

[dbu]

i do mean the superglobal. we can also go for always localhost. its just for the edge case of //. we have to rethink this for 2.0 but in 1.x i dont want to change this behaviour so fundamentally. hopefully "match(path)" wont exist anymore for 2.0 (symfony 3)

[dbu]

superseeded by #163