unset _locale parameter if matching route has been found

[uwej711]

See issue #55

[dbu]

thanks

[dbu]

hm. what if there is {_locale} in the route? should we check that before unsetting?

[uwej711]

Hi,

What about variables in the route patterns at all?

Cheers
Uwe

Am 05.04.2013 um 11:06 schrieb David Buchmann notifications@github.com:

hm. what if there is {_locale} in the route? should we check that before unsetting?

—
Reply to this email directly or view it on GitHub.

[lsmith77]

we do have the locale in the route when using the SimpleCmsBundle in the multilang mode (like we do in the SE).

[uwej711]

So you create a node with name {_locale} at the top of the routing tree? If
that's possible this PR is wrong and should be reverted.

2013/4/5 Lukas Kahwe Smith notifications@github.com

we do have the locale in the route when using the SimpleCmsBundle in the
multilang mode (like we do in the SE).

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/56#issuecomment-15946000
.

[dbu]

I fear we have to string-search for that in the pattern. Or would getParameters work here to check?

----- Reply message -----
Von: "Uwe Jäger" notifications@github.com
An: "symfony-cmf/Routing" Routing@noreply.github.com
Cc: "David Buchmann" david@liip.ch
Betreff: [Routing] unset _locale parameter if matching route has been found (#56)
Datum: Fr., Apr. 5, 2013 11:47
So you create a node with name {_locale} at the top of the routing tree? If

that's possible this PR is wrong and should be reverted.

2013/4/5 Lukas Kahwe Smith notifications@github.com

we do have the locale in the route when using the SimpleCmsBundle in the

multilang mode (like we do in the SE).

—

Reply to this email directly or view it on GitHubhttps://github.com//pull/56#issuecomment-15946000

.

—
Reply to this email directly or view it on GitHub.

[lsmith77]

no we do this dynamically in the route provider. but yes in the end there is a _locale placeholder. check the SE

[uwej711]

You do it in SimpleCmsBundle\Document\MultilangRoute.php

This could be part of the RoutingExtraBundle ?

[lsmith77]

sorry .. i was unclear before .. its done inside the Route itself:
https://github.com/symfony-cmf/SimpleCmsBundle/blob/master/Document/MultilangPage.php#L71

[uwej711]

So I propose the following: we compile the route already in ContentAwareGenerator and check the variables for _locale. If it is not there, it can be safely unset. I'll try to do a PR for that.

[dbu]

that sounds like an excellent idea. it does not cost us anything as the
compiled route is cached when unchanged. and we won't change it at that
point. thanks uwe.