update vendors and adjust to seo bundle changes

[dbu]

preparing with updated bundles

[dbu]

seo metadata extras editing is currently broken - i created Burgov/KeyValueFormBundle#2

[ElectricMaxxx]

👍

[ElectricMaxxx]

I think i will try to dive on my own into that part this evening or tomorrow Morning at work. Will have a look how it should work or what that bundle expects to get.

[lsmith77]

guess still makes sense to merge?

[ElectricMaxxx]

@dbu it's the reflection again that hits us in here. As you can see in the Exception Symfony\Cmf\Bundle\SeoBundle\Doctrine\Phpcr\SeoMetadata has no method addExtraName() and indeed that class does not have that method, but the Symfony\Cmf\Bundle\SeoBundle\Model\SeoMetadata has. So that exception is thrown, cause that check is done by a reflection, which does not work on extensions as i had to learn. So we can't really say if our signature of the adder are right or not, cause we didn't touch them by the form.

[ElectricMaxxx]

... and symfony form goes that way only for values that are arrays. Could be a reason why it does not occur that much. Simple non-array are set by setters always.

[ElectricMaxxx]

..., but even or adder would be found we would get an error cause as you can see in
https://github.com/symfony/symfony/blob/master/src/Symfony/Component/PropertyAccess/PropertyAccessor.php#L489-L491
and
https://github.com/Burgov/KeyValueFormBundle/blob/master/Form/DataTransformer/HashToKeyValueArrayTransformer.php#L19-36
the value only would be set and as the first param.

So what to do?

• solve the reflection thing
• discuss in bug with using the form Burgov/KeyValueFormBundle#2, what the right signature our solution withadd*($key, $value)` would be the best i think.

[ElectricMaxxx]

Tried to fix the last item by Burgov/KeyValueFormBundle#3

[dbu]

burgov said he would look into the issue today, so lets wait a moment to hear from him.

[dbu]

@ElectricMaxxx i think you are mistaken about the reflection: if i change the method to have just one argument, things work indeed fine, php sees the method of the parent class. (if it would not, reflection would be broken quite fundamentally)

[ElectricMaxxx]

@dbu you are right, sorry. I do not see this part of code in the PropertyAccessor

    private function isAccessible(\ReflectionClass $class, $methodName, $parameters)
    {
        if ($class->hasMethod($methodName)) {
            $method = $class->getMethod($methodName);

            if ($method->isPublic() && $method->getNumberOfRequiredParameters() === $parameters) {
                return true;
            }
        }

        return false;
    }

That checks the existence and the number of parameters. So it just the discussion whit burgov is left.

[ElectricMaxxx]

@dbu tried symfony-cmf/seo-bundle#157 together with https://github.com/Burgov/KeyValueFormBundle/compare/key-value-container-object and it works fine then.