Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ckeditor image upload functionality #62

Merged
merged 1 commit into from
Jul 19, 2013
Merged

Conversation

rdotter
Copy link
Contributor

@rdotter rdotter commented Jul 11, 2013

#59

@rmsint rmsint mentioned this pull request Jul 19, 2013
5 tasks
@dbu
Copy link
Member

dbu commented Jul 19, 2013

thanks a lot for this PR, and sorry for not looking into it sooner.

we seem to have a few setup errors with ckeditor, that are not related to this PR but will become annoying when ckeditor becomes the default editor. i will try to fix them in master.

i got this to run locally, can upload images and get to see them - until i save, at which point the whole tag gets removed from the content. did that work for you? playing around some more, i just realize that often the very last change does not get stored. so if i type xxx after inserting the image, i get the tag and xx but not the 3rd x. any idea why that could be happening here, is it a sync problem between ckeditor and create.js? would be awesome if we could fix this.

@dbu
Copy link
Member

dbu commented Jul 19, 2013

/cc @sjopet did you ever encounter this issue when working with elfinder? do you have a specific version of ckeditor (maybe an older one that did not do the change that makes create.js not play well?

@dbu
Copy link
Member

dbu commented Jul 19, 2013

seems to be a known issue on create side actually: bergie/create#178 i guess we should try to help them to fix that and then update the create version we use.

i will already merge the rest of this PR but not yet make ckeditor default.

@dbu dbu merged commit e26575b into symfony-cmf:master Jul 19, 2013
@@ -157,7 +157,17 @@ public function uploadAction(Request $request)

$this->manager->flush();

return $this->generateUploadResponse($id, $image, $file);
// file upload via CKEditor
if ($request->query->get('CKEditor')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably be configured in the class rather.

@dbu
Copy link
Member

dbu commented Jul 19, 2013

we should look into these issues in #60

@lsmith77
Copy link
Member

docs also need to be updated http://symfony.com/doc/master/cmf/bundles/create.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants