Question

[mssimi]

Hey, why is loader checking instance twice?

https://github.com/symfony-cmf/menu-bundle/blob/master/src/Loader/VotingNodeLoader.php#L45
https://github.com/symfony-cmf/menu-bundle/blob/master/src/Loader/VotingNodeLoader.php#L74

It goes throught $this->supports anyway, coz of recursion. Or is there any reason why u want to skip throwing exception?

[dbu]

hi. the loop skips children that don't implement the interface. the document could have non-menu children and we want to ignore those. if we would just call the recursion, we would end up with an exception Am 17.05.2017 9:05 nachm. schrieb "Marek Šimeček" <notifications@github.com

:

Hey, why is loader checking instance twice? https://github.com/symfony-cmf/menu-bundle/blob/master/ src/Loader/VotingNodeLoader.php#L45 <http://url> https://github.com/symfony-cmf/menu-bundle/blob/master/ src/Loader/VotingNodeLoader.php#L74 <http://url> It goes throught $this->supports anyway, coz of recursion. Or is there any reason why u want to skip throwing exception? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#290>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAErIGWEy0XyvWRzfrfpnO3334WYRRW-ks5r60UDgaJpZM4NeTy4> .

[mssimi]

Sounds weird to me, why combing menu-items and non-menu items in menu. I dont see real usage, but whatever:)

[dbu]

i would not recommend it, but when it happens, whether by accident or on purpose, the site should not break.