This repository has been archived by the owner on Sep 16, 2021. It is now read-only.
Document the CreateMenuItemFromNodeEvent #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dbu
commented
Apr 15, 2014
dbu
commented
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | dev |
| Fixed tickets | symfony-cmf/menu-bundle#175 |
| This listener handles menu nodes that point to a different menu by implementing | ||
| the ``MenuReferrerInterface``:: | ||
|
|
||
| namespace Example\Menu; |
There was a problem hiding this comment.
And why not just Acme\DemoBundle or the like?
|
and updated. |
| **Note:** If setSkipNode(true) is called for ``Menu`` the | ||
| ``ContentAwareFactory`` will still create an empty item for the menu. This is | ||
| to prevent the KnpMenuBundle code from throwing an Exception due to null | ||
| being passed to a function to render a menu. |
There was a problem hiding this comment.
semi colons :) (sorry missed that before)
|
thanks, updated. |
|
anything missing or good to merge? |
|
@dbu I think its good |
wouterj
added a commit
that referenced
this pull request
Apr 23, 2014
Document the CreateMenuItemFromNodeEvent
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.