Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

cleanup seo documentation #823

Merged
merged 1 commit into from
Jun 17, 2017
Merged

cleanup seo documentation #823

merged 1 commit into from
Jun 17, 2017

Conversation

dbu
Copy link
Member

@dbu dbu commented Jun 15, 2017

fixes part of #786 and #787

Copy link
Member

@ElectricMaxxx ElectricMaxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine except an minor hint i would add. I think we should add all admin integration stuff one by one and read through it, when it lives together to see if it looks equal.


**type**: ``string`` **default**: ``form.group_seo``

The name of the form group to use in the admin extension.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is used as a translation key, so customization means adding an own key. (Same for all of them)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good find, thanks for spotting! we missed this doc for most admins. i made partials and use these now where appropriated.

@dbu dbu force-pushed the seo-doc-update branch 3 times, most recently from e690c69 to bcf561a Compare June 17, 2017 12:49
@dbu dbu merged commit fea9384 into 2.0 Jun 17, 2017
@dbu dbu deleted the seo-doc-update branch June 17, 2017 21:08
@dbu
Copy link
Member Author

dbu commented Jun 17, 2017

thanks max, very good point about the admin integration. i ended up doing a partial and adding that to other places with admin integration as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants