Skip to content

Commit

Permalink
bug #1046 Fix demo password autofill on Firefox (bocharsky-bw)
Browse files Browse the repository at this point in the history
This PR was merged into the master branch.

Discussion
----------

Fix demo password autofill on Firefox

This PR fixes demo password auto-filling on Firefox, steps to reproduce:
1. Open the login page in FF: https://localhost:8000/en/login
2. Reload the page and see empty password - looks like FF clears it due to security reasons but keeps the username

Commits
-------

c57a9a0 Fix demo password autofill on Firefox
  • Loading branch information
javiereguiluz committed Nov 25, 2019
2 parents 28e2ee6 + c57a9a0 commit c0ccc57
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion assets/js/login.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ $(function() {

// in a real application, hardcoding the user/password would be idiotic
// but for the demo application it's very convenient to do so
if (!usernameEl.val() && !passwordEl.val()) {
if (!usernameEl.val() || 'jane_admin' === usernameEl.val()) {
usernameEl.val('jane_admin');
passwordEl.val('kitten');
}
Expand Down
2 changes: 1 addition & 1 deletion public/build/app.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions public/build/entrypoints.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,9 @@
"/build/runtime.js": "sha384-/Zh0hTCgqMfXwZfeMIiueZzsKiHkvtqEOzKpZAuznIbgqg1DQpUQAwwNlO/9ToVH",
"/build/0.js": "sha384-Dt6rncfcL40e91sPDLy/fZ8XgfH6ZZmLY1+ajXaPmGFGTb5XNtWS5jmf84NoZT/f",
"/build/1.js": "sha384-bmKW9QGT6CjdvJr6hoYLCByhKzyjU+g+gUJ5SGOSxqUm4jzLuBhDpl0hImY/1R3M",
"/build/app.js": "sha384-/3gf9IHx1zzgGuRgdnnW/2AJBU896jAJn1dDLJLb3vBkLQkE8WvI3ycZt0l0GECV",
"/build/app.js": "sha384-uCtNC3fXHx82+vdtTkHRXofGzNn6MJtN1ChaO2RaxA2IaRj/Ybj3QNldmJ6X0jI1",
"/build/app.css": "sha384-NGTdnyfcvVpvCvvEryRps/xU6Mb67YeTf1pvFrUkd80uXKIuxzYmcXzvzttKu4d0",
"/build/login.js": "sha384-tCP53hf/3uu7W5h5syxKODJjjos7AyGM/lENitUwFKSXMxQsWP+50V0mN6bcImAo",
"/build/login.js": "sha384-w5qwGnj2mp4pazKe9KGCQU+FR1n/717WouCp594UxY7HHGLafcGrZ9mrFR68V6oe",
"/build/2.js": "sha384-zrtPryvCde+sRepOgkuLELopii2NoIgS3rrkpCfY8e7nT359Sc0tXRG2QqsKLfEO",
"/build/admin.js": "sha384-My30UK7GowsN0RikK0XGQk7gvdtxxZsz2f52md+YoV4YZu4yjMArjwO7ZwE7K4av",
"/build/admin.css": "sha384-NMnc2b6jJOZO4QiUk4TgitF+ipl41B2+0TFmAwGqpQ6cinY6Q6mb1watPtAAWkAZ",
Expand Down
2 changes: 1 addition & 1 deletion public/build/login.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c0ccc57

Please sign in to comment.