Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctrine/annotations dependency tells to require sensio/framework-extra-bundle #442

Closed
MatTheCat opened this issue Jul 11, 2019 · 3 comments · Fixed by #445
Closed

doctrine/annotations dependency tells to require sensio/framework-extra-bundle #442

MatTheCat opened this issue Jul 11, 2019 · 3 comments · Fixed by #445

Comments

@MatTheCat
Copy link
Contributor

When I tried to use make:controller I got

[ERROR] Missing package: to use the make:controller command, run:

    composer require annotations 

which I ran, before realizing it was installing sensio/framework-extra-bundle.

That surprised me because you're no longer supposed to require this bundle to annotate routes. Then I saw

we only need doctrine/annotations

in https://github.com/symfony/maker-bundle/blob/master/src/Maker/MakeController.php#L89

So why does it ask to install sensio/framework-extra-bundle?

This also concerns MakeRegistrationForm.

@MatTheCat
Copy link
Contributor Author

I just found symfony/symfony-docs#10426

So basically we want the user to install the whole framework-extra-bundle because they may need it??

@weaverryan
Copy link
Member

I’d be ok with changing to doctrine-annotations. Though, that change can only be made for makers that don’t rely on the param converter from FwExtraBundle.

@MatTheCat
Copy link
Contributor Author

These are MakeRegistrationForm and MakeController. I could submit a PR tomorrow.

weaverryan added a commit that referenced this issue Aug 12, 2019
…ra-bundle where sufficient (MatTheCat)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Require doctrine/annotations instead of sensio/framework-extra-bundle where sufficient

Fixes #442

Commits
-------

3ff6a75 Replace annotations with doctrine/annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants