-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add maker command for form type extensions #85
Conversation
Anyone there!? :) very low review activity on this amazing new bundle by the way 🚤 I'd like to put 2th gear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks OK to me. Thanks Yonel.
@javiereguiluz thanks for the minor reword ;) it looks better now. |
Hey @yceruto! Sorry for the delay - I wanted to get the new functional test system in place before working on any additional makers. Imo, I would prefer option (2): where we allow the user to type in the extended type, but help them a bit (because yea, nobody wants to type the long class name, Could you update the maker for these changes? Also, the
I agree :D. I think it's because I've been busy with some "boring" low-level tasks, but those are done now! |
Hi! happy new year to everyone 🎉 @weaverryan yeah, i'll try to do it this weekend, cheers. |
481fb0c
to
9e7b3e0
Compare
9e7b3e0
to
a0d0c50
Compare
Latest changes:
Ready for review! |
Updated description with preview! |
this is ready from my side... ;) |
891b7e5
to
9b54e8c
Compare
I'm closing here because I can't fix this after rebase on master. |
@yceruto sorry about that - I should have communicated better. I wanted to get a few internal updates done (which are now done) before merging this. If you can’t rebate, I understand. But both of your PR’s are good imo :) |
I've two versions of this command:
FormType::class
. Then, the user is responsible for changing it if necessary (with IDE autocompletion this task is very fast).debug:form <FormType>
argument.closes #78