Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set visibility on class constants #868

Merged
merged 1 commit into from May 4, 2021
Merged

set visibility on class constants #868

merged 1 commit into from May 4, 2021

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented May 4, 2021

sets the visibility modifier for class constants

@jrushlow jrushlow mentioned this pull request May 4, 2021
Merged
3 tasks
@jrushlow jrushlow force-pushed the feature/class-const-visibility branch from 6111870 to 8b45487 Compare May 4, 2021 11:45
@weaverryan
Copy link
Member

Thanks Jesse!

@weaverryan weaverryan merged commit c6330a3 into symfony:main May 4, 2021
@jrushlow jrushlow deleted the feature/class-const-visibility branch May 4, 2021 17:17
weaverryan added a commit that referenced this pull request May 4, 2021
@weaverryan
minor #867 [ci] upgrade php-cs-fixer 2.x -> 3.0 (jrushlow)
c4f7ba9 
This PR was squashed before being merged into the 1.0-dev branch.

Discussion
----------

[ci] upgrade php-cs-fixer 2.x -> 3.0

- [ ] depends on symfony/recipes#942
- [x] depends on #868
- [x] depends on #869

Commits
-------

2396836 [ci] upgrade php-cs-fixer 2.x -> 3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrushlow @weaverryan @OskarStark