[make:serializer:encoder] set public constant visibility modifier #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
weaverryan
reviewed
May 4, 2021
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| class <?= $class_name ?> implements EncoderInterface, DecoderInterface | |||
| { | |||
| const FORMAT = '<?= $format ?>'; | |||
| public const FORMAT = '<?= $format ?>'; | |||
There was a problem hiding this comment.
Hmm, but what's the use-case (why make it public) for it being public?
|
I'm merging - but I'm still not sure about the tiny detail of whether the visiblity should be public or private :) |
weaverryan
added a commit
that referenced
this pull request
May 4, 2021
This PR was squashed before being merged into the 1.0-dev branch. Discussion ---------- [ci] upgrade php-cs-fixer 2.x -> 3.0 - [ ] depends on symfony/recipes#942 - [x] depends on #868 - [x] depends on #869 Commits ------- 2396836 [ci] upgrade php-cs-fixer 2.x -> 3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP 7.1 - class constants can have a visibility modifier. The Symfony coding standards require the visibility modifier to be set.
make:serializer:encodernow defaults to thepublicmodifier for theFORMATconst.