Throw explanative LogicException when driver is not started yet
#268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanlaak
force-pushed
the
no-driver-logicexception
branch
from
a1b01a6
to
faab6ef
Compare
dunglas
approved these changes
Dec 17, 2019
tests/ClientTest.php
Outdated
| @@ -17,7 +17,8 @@ | |||
| use Facebook\WebDriver\JavaScriptExecutor; | |||
| use Facebook\WebDriver\WebDriver; | |||
| use Facebook\WebDriver\WebDriverExpectedCondition; | |||
| use Symfony\Component\BrowserKit\Client as BrowserKitClient; | |||
| use LogicException; | |||
There was a problem hiding this comment.
We use \LogicException instead of this in Symfony.
There was a problem hiding this comment.
As in, you mean not importing the exception class? Ok, did change that in ea9d7d1.
rvanlaak
force-pushed
the
no-driver-logicexception
branch
from
f3f18ee
to
ea9d7d1
Compare
This PR actually fixes CI for PHP 7.2 , which is failing on @dunglas would you be ok with me adding PHPStan in a separate PR and run it via Github Actions? See php-translation/symfony-storage#38 and theiconic/name-parser#41 and rvanlaak/SettingsBundle#110 as examples 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
executeScriptgets called before the client made a request, an exception should get thrown. The problem; the actualRuntimeExceptioncan not get created because driver isnull.This PR clarifies that these methods can not get called before the driver is started.
Failing test on linting / phpstan does not seem related (?). Is it because of the 0.12 phpstan release of several days ago?