throw explanative LogicException when driver is not started yet
#373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
force-pushed
the
no-driver-logicexception
branch
from
12c19b1
to
e5e97d9
Compare
|
Thanks @rvanlaak |
|
Planning on a new release? Are there things I can help with? |
|
@rvanlaak yes I'm on it. What's left to do is documenting the new features and writing the changelog (v0.7.1...master, #375). Help to finish open PRs or to close open issues is also very welcome! |
dunglas
added a commit
that referenced
this pull request
Dec 28, 2020
* throw explanative `LogicException` when driver is not started yet * fix: phpstan Co-authored-by: Richard van Laak <rvanlaak@gmail.com>
nicolas-grekas
pushed a commit
that referenced
this pull request
Jan 18, 2021
* throw explanative `LogicException` when driver is not started yet * fix: phpstan Co-authored-by: Richard van Laak <rvanlaak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes and closes #268. cc @rvanlaak