-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHPStan Github action #110
Conversation
Could you also add a baseline? |
Done, added baseline. And learned something new Today. Apparently |
Cool! |
@@ -0,0 +1,13 @@ | |||
name: Static code analysis | |||
|
|||
on: [push] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be on push
and pull_request
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still didn't find a situation where solely push
didn't run the tests. Adding them both on the contrary will run the tests twice when you open a PR.
What about leaving it for now? I'll file a PR if it causes problems 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you do a PR from a fork, then this will action will never run.
Feel free to merge this now and do a PR from a fork later to try yourself.
I'm in favor of just merging this PR, and decide on fixing / adding baseline later.