Skip to content

Commit

Permalink
minor #5552 rename $input to $greetInput (Xosofox)
Browse files Browse the repository at this point in the history
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #5552).

Discussion
----------

rename $input to $greetInput

Not a good practice to set/abuse a variable that was passed as an argument

Commits
-------

53b4a3d rename $input to $greetInput
  • Loading branch information
wouterj committed Jul 22, 2015
2 parents a0a2575 + 53b4a3d commit 408c102
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions components/console/introduction.rst
Original file line number Diff line number Diff line change
Expand Up @@ -469,8 +469,8 @@ Calling a command from another one is straightforward::
'--yell' => true,
);

$input = new ArrayInput($arguments);
$returnCode = $command->run($input, $output);
$greetInput = new ArrayInput($arguments);
$returnCode = $command->run($greetInput, $output);

// ...
}
Expand Down

0 comments on commit 408c102

Please sign in to comment.