Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename $input to $greetInput #5552

Closed
wants to merge 1 commit into from
Closed

rename $input to $greetInput #5552

wants to merge 1 commit into from

Conversation

xosofox
Copy link
Contributor

@xosofox xosofox commented Jul 22, 2015

Not a good practice to set/abuse a variable that was passed as an argument

@xosofox
rename $input to $greetInput
c075bbb 
Not a good practice to set/abuse a variable that was passed as an argument
@stof
Copy link
Member

stof commented Jul 22, 2015

👍

@xabbuh
Copy link
Member

xabbuh commented Jul 22, 2015

👍

@wouterj
Copy link
Member

wouterj commented Jul 22, 2015

Much better! Thanks Peter.

wouterj added a commit that referenced this pull request Jul 22, 2015
@wouterj
minor #5552 rename $input to $greetInput (Xosofox)
408c102 
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #5552).

Discussion
----------

rename $input to $greetInput

Not a good practice to set/abuse a variable that was passed as an argument

Commits
-------

53b4a3d rename $input to $greetInput
@wouterj wouterj closed this Jul 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xosofox @stof @xabbuh @wouterj