Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Validator] Document disable_not_compromised_password option #11327

Closed
lyrixx opened this issue Apr 6, 2019 · 3 comments
Closed

[Validator] Document disable_not_compromised_password option #11327

lyrixx opened this issue Apr 6, 2019 · 3 comments
Assignees
@javiereguiluz
Labels
⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming hasPR A Pull Request has already been submitted for this issue. Validator
Milestone
4.3

Comments

@lyrixx
Copy link
Member

lyrixx commented Apr 6, 2019 •
edited
Loading

Refs : symfony/symfony#30932

Usage:

framework:
    validation:
        disable_not_compromised_password: true

EUFOSSA
@lyrixx lyrixx mentioned this issue Apr 6, 2019
Merged
@lyrixx lyrixx changed the title [Validator] Comment disable_not_compromised_password option [Validator] Document disable_not_compromised_password option Apr 6, 2019
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this issue Apr 6, 2019
@fabpot
feature #30932 [Validator] Add an option to disable NotCompromisedPas…
3762297 
…swordValidator (lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Validator] Add an option to disable NotCompromisedPasswordValidator

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30871
| License       | MIT
| Doc PR        | symfony/symfony-docs#11327

EUFOSSA

Commits
-------

9a2787e89a [Validator] Add an option to disable NotCompromisedPasswordValidator
symfony-splitter pushed a commit to symfony/validator that referenced this issue Apr 6, 2019
@fabpot
feature #30932 [Validator] Add an option to disable NotCompromisedPas…
ded8491 
…swordValidator (lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Validator] Add an option to disable NotCompromisedPasswordValidator

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30871
| License       | MIT
| Doc PR        | symfony/symfony-docs#11327

EUFOSSA

Commits
-------

9a2787e89a [Validator] Add an option to disable NotCompromisedPasswordValidator
fabpot added a commit to symfony/symfony that referenced this issue Apr 6, 2019
@fabpot
feature #30932 [Validator] Add an option to disable NotCompromisedPas…
f80df4c 
…swordValidator (lyrixx)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Validator] Add an option to disable NotCompromisedPasswordValidator

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #30871
| License       | MIT
| Doc PR        | symfony/symfony-docs#11327

EUFOSSA

Commits
-------

9a2787e [Validator] Add an option to disable NotCompromisedPasswordValidator
@OskarStark OskarStark added Waiting Code Merge Docs for features pending to be merged ⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Validator labels Apr 6, 2019
@maxhelias
Copy link
Contributor

The PR is merge, the issue may be closed ?

@xabbuh xabbuh added this to the 4.3 milestone Apr 7, 2019
@xabbuh
Copy link
Member

xabbuh commented Apr 7, 2019

@maxhelias That's only the code PR, isn't it?

@xabbuh xabbuh removed the Waiting Code Merge Docs for features pending to be merged label Apr 7, 2019
@maxhelias
Copy link
Contributor

Yes, I was wrong in the repository 😅

@javiereguiluz javiereguiluz self-assigned this Apr 8, 2019
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Apr 8, 2019
@javiereguiluz javiereguiluz mentioned this issue Apr 8, 2019
Merged
OskarStark added a commit that referenced this issue Apr 8, 2019
@OskarStark
minor #11354 Documented the disable_not_compromised_password option (…
c2b30f0 
…javiereguiluz)

This PR was squashed before being merged into the master branch (closes #11354).

Discussion
----------

Documented the disable_not_compromised_password option

Fixes #11327 and documents symfony/symfony#30932.

Commits
-------

038d9b7 Documented the disable_not_compromised_password option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javiereguiluz javiereguiluz

Labels
⭐️ EU-FOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming hasPR A Pull Request has already been submitted for this issue. Validator
Projects
None yet
Milestone
4.3
Development

No branches or pull requests
5 participants
@javiereguiluz @lyrixx @OskarStark @xabbuh @maxhelias